Re: [RFC PATCH 7/8] ASoC: Intel: Skylake: Update PCI ID list

Amadeusz Sławiński
2023-06-29T08:22:00Z

On 6/28/2023 4:52 PM, Andy Shevchenko wrote:
> On Wed, Jun 28, 2023 at 10:51:34PM +0200, Amadeusz Sławiński wrote:
>> Use PCI device IDs from pci_ids.h header and while at it change to using
>> PCI_DEVICE_DATA macro, to simplify declarations.
>
> PCI_DEVICE_DATA()
>
> ...
>
>> + { PCI_DEVICE_DATA(INTEL, HDA_SKL_LP, &snd_soc_acpi_intel_skl_machines) },
>
> Do you really need TAB(s) in the parameter list?
>

I did this to align entries, I know it is not that visible in this
patch, but they are defined close to each other and I feel that it looks
better if they are aligned, but can drop alignment if you prefer. Should
I also drop them in other patches, as I don't see comment for that?