Re: [RFC PATCH 8/8] ASoC: SOF: Intel: Update PCI ID list

Andy Shevchenko
2023-06-28T14:55:29Z

On Wed, Jun 28, 2023 at 10:51:35PM +0200, Amadeusz Sławiński wrote:
> Use PCI device IDs from pci_ids.h header and while at it change to using
> PCI_DEVICE_DATA macro, to simplify declarations.

PCI_DEVICE_DATA()

...

> + { PCI_DEVICE_DATA(INTEL, HDA_APL, &bxt_desc) },

TAB(s) vs single space?

...

> static const struct pci_device_id sof_pci_ids[] = {
> - { PCI_DEVICE(0x8086, 0x119a),
> - .driver_data = (unsigned long)&tng_desc},
> + { PCI_DEVICE_DATA(INTEL, HDA_MRFLD, &tng_desc) },

Is it HDA? IIRC it was called Intel SST or so.

> { 0, }
> };

Also with the file name, I think the ID itself should use TNG suffix.

--
With Best Regards,
Andy Shevchenko