From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Liao, Bard" <yung-chuan.liao@linux.intel.com>,
"Lu, Brent" <brent.lu@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhi, Yong" <yong.zhi@intel.com>,
Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
"Bhat, Uday M" <uday.m.bhat@intel.com>,
Terry Cheong <htcheong@chromium.org>,
"Chiang, Mac" <mac.chiang@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
Date: Thu, 27 Jul 2023 07:41:53 +0200 [thread overview]
Message-ID: <bbf9baf1-d55b-b846-740f-1ed8976b82b4@linux.intel.com> (raw)
In-Reply-To: <c1aadbcf-78ab-0566-84e5-8eaa7b418d50@linux.intel.com>
On 7/27/23 5:21 AM, Liao, Bard wrote:
>
> On 7/27/2023 10:14 AM, Lu, Brent wrote:
>>>
>>> max_98390_components[] and max_98390_4spk_components[] are still used
>>>
>>> by sof_rt5682.c, we should remove them in the same patch.
>>>
>>> Maybe combine the 2 patches together?
>>>
>>>
>> I've got your point but these two patches are doing two things: one is
>> refactor the
>> code and add a detection feature, the other one is removing the quirk.
>> Not sure if
>> it's proper to merge them.
>
> The point is that if you remove them and they are still used somewhere,
>
> you will break the build. i.e. Kernel will not compile if we apply the
>
> first patch only.
IOW git bisect is broken and that's a big no-no.
next prev parent reply other threads:[~2023-07-27 5:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 9:26 [PATCH 0/2] Intel: sof_rt5682: remove quirk flag Brent Lu
2023-07-20 9:26 ` [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI Brent Lu
2023-07-24 9:08 ` Pierre-Louis Bossart
2023-07-24 9:52 ` Andy Shevchenko
2023-07-24 11:06 ` Lu, Brent
2023-07-24 11:16 ` Andy Shevchenko
2023-07-26 6:16 ` Lu, Brent
2023-07-26 8:47 ` Liao, Bard
2023-07-26 11:25 ` Liao, Bard
2023-07-27 2:14 ` Lu, Brent
2023-07-27 3:21 ` Liao, Bard
2023-07-27 5:41 ` Pierre-Louis Bossart [this message]
2023-07-27 11:36 ` Mark Brown
2023-07-28 6:12 ` Lu, Brent
2023-07-20 9:26 ` [PATCH 2/2] ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag Brent Lu
2023-07-21 9:53 ` [PATCH 0/2] Intel: sof_rt5682: remove quirk flag Kai Vehmanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbf9baf1-d55b-b846-740f-1ed8976b82b4@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dharageswari.r@intel.com \
--cc=htcheong@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=uday.m.bhat@intel.com \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox