From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>
Subject: Re: [PATCH v1 1/2] i2c: designware-pci: Group AMD NAVI quirk parts together
Date: Thu, 29 Sep 2022 08:52:15 +0300 [thread overview]
Message-ID: <bc058878-4df4-cdcb-db6b-7c88e8814aa4@linux.intel.com> (raw)
In-Reply-To: <20220928162116.66724-1-andriy.shevchenko@linux.intel.com>
On 9/28/22 19:21, Andy Shevchenko wrote:
> The code is ogranazed in a way that all related parts to
> the certain platform quirk go toghether. This is not the
> case for AMD NAVI. Shuffle code to make it happen.
>
Perhaps you want to change ogranazed and toghether?
> While at it, drop the frequency definition and use
> hard coded value as it's done for other platforms and
> add a comment to the PCI ID list.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 30 +++++++++++-----------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
You may add:
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-09-29 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 16:21 [PATCH v1 1/2] i2c: designware-pci: Group AMD NAVI quirk parts together Andy Shevchenko
2022-09-28 16:21 ` [PATCH v1 2/2] i2c: designware-pci: Use standard pattern for memory allocation Andy Shevchenko
2022-09-29 5:52 ` Jarkko Nikula
2022-09-29 5:52 ` Jarkko Nikula [this message]
2022-09-29 9:42 ` [PATCH v1 1/2] i2c: designware-pci: Group AMD NAVI quirk parts together Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc058878-4df4-cdcb-db6b-7c88e8814aa4@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox