From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759526AbdAJJj2 (ORCPT ); Tue, 10 Jan 2017 04:39:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759327AbdAJJj1 (ORCPT ); Tue, 10 Jan 2017 04:39:27 -0500 Subject: Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() To: Peter Xu , David Hildenbrand References: <20161216151006.11776-1-rkrcmar@redhat.com> <20161216151006.11776-3-rkrcmar@redhat.com> <20170110050958.GI4135@pxdev.xzpeter.org> Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Paolo Bonzini Message-ID: Date: Tue, 10 Jan 2017 10:39:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170110050958.GI4135@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 10 Jan 2017 09:39:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/2017 06:09, Peter Xu wrote: >> Was wondering if FULL/SPLIT would be a better naming. However I also >> find irqchip_kernel() vs irqchip_in_kernel() slightly confusing. > Me too. Since we have kvm_irqchip_mode enum above, how about renaming > irqchip_{kernel|split}() into irqchip_mode_{kernel|split}()? > > Sorry for such a late comment... No problem, it can be done on top. Another thing to do is to make irqchip_in_kernel check mode != NONE. Paolo