The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: zhuyinbo <zhuyinbo@loongson.cn>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
	wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
	loongson-kernel@lists.loongnix.cn,
	zhanghongchen <zhanghongchen@loongson.cn>,
	zhuyinbo@loongson.cn
Subject: Re: [PATCH v14 1/2] thermal: loongson-2: add thermal management support
Date: Sat, 17 Jun 2023 11:25:40 +0800	[thread overview]
Message-ID: <bc081559-e6f5-7ac8-7ae1-3cfbbee51697@loongson.cn> (raw)
In-Reply-To: <af4d1e00-76d6-b71a-2ed1-562e6405306b@linaro.org>


Hi Daniel,

在 2023/6/12 下午10:22, Daniel Lezcano 写道:

...

>>
>> +#define LOONGSON2_SOC_MAX_SENSOR_NUM            4
>> +
>> +#define LOONGSON2_TSENSOR_CTRL_HI            0x0
>> +#define LOONGSON2_TSENSOR_CTRL_LO            0x8
>> +#define LOONGSON2_TSENSOR_STATUS            0x10
>> +#define LOONGSON2_TSENSOR_OUT                0x14
> 
> Please use BIT() macros


I learn about that BIT() is generally used to describe the functional
bit or control bit or status bits of a register, but these register was
some different register offset and not some control bit or status bit
So using BIT() here seems a bit inappropriate, Do you think so?


Thanks,
Yinbo


  parent reply	other threads:[~2023-06-17  3:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26  6:20 [PATCH v14 1/2] thermal: loongson-2: add thermal management support Yinbo Zhu
2023-04-26  6:20 ` [PATCH v14 2/2] dt-bindings: thermal: add loongson-2 thermal Yinbo Zhu
2023-06-09  9:22 ` [PATCH v14 1/2] thermal: loongson-2: add thermal management support zhuyinbo
2023-06-12 14:22 ` Daniel Lezcano
2023-06-14  8:03   ` zhuyinbo
2023-06-14 10:59     ` Daniel Lezcano
2023-06-15  2:57       ` zhuyinbo
2023-06-16 14:34         ` [PATCH] thermal/drivers/loongson2: Fix thermal zone private data access Daniel Lezcano
2023-06-16 14:35           ` Daniel Lezcano
2023-06-17  1:52             ` zhuyinbo
2023-06-17  7:12               ` Daniel Lezcano
2023-06-17  7:23                 ` zhuyinbo
2023-06-17  3:25   ` zhuyinbo [this message]
2023-06-17  7:15     ` [PATCH v14 1/2] thermal: loongson-2: add thermal management support Daniel Lezcano
2023-06-17  7:25       ` zhuyinbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc081559-e6f5-7ac8-7ae1-3cfbbee51697@loongson.cn \
    --to=zhuyinbo@loongson.cn \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=liupeibao@loongson.cn \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=lvjianmin@loongson.cn \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=wanghongliang@loongson.cn \
    --cc=zhanghongchen@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox