From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9506B3DC4C4 for ; Wed, 6 May 2026 09:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778058558; cv=none; b=pw8+i0a4m/VbrsfxBvXncq0toAg52TCLWagWfvHwjhxnxpAtlWw/97LaBHmBoIngymhhIDItQm49XSQMVLPFP+/EMEmi2c53k+LFzcxKUUl9hia2R0jAUVLMODHtt8k50vqxGKcM6KiZTidkup8FMnj00vxcMEhwXSbCEhX3iOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778058558; c=relaxed/simple; bh=M7QugAnyBIj+pMsgaMpxiuwM8+h/OjfhY50NRM/u2V0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DqCAza+Ift18RZqtxeBoYuE2Rp0xolHZxaHixSRel5yXvj+g7l5Ryvps7uCvtiXbb5WN6/F3PuspCGZ43atXWJ+Tka6Aqrb36pOzRadZ5QenHZWaQReRvHYSsYfLRslU2nS3L6yc1J3rXZZOAJ6w5dgywBk7PVU6YoRiMux2kh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iQHh5D8i; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DxJyOcoX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iQHh5D8i"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DxJyOcoX" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6467trJM2427920 for ; Wed, 6 May 2026 09:09:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /QYN4YHTbAvld9AKdLcRu1XRlvWseqFmomQUeK7fiaw=; b=iQHh5D8i1Htl5v1K zc8EC/rwj4IW5rWna26tmQoUV/n8on5fTRnTGnu8UDoVSgE6QiyDmH2BdoZGksRR DgAvdQzvARnD2IQRpH4T4AaO/YqjNLjYpOlN08dBq+JUP1t1OxicC6tCjIDDHQnk ILVqCJUzXSuplRS/EbGOTpdFT51W9ysr3YWiI49CN1tNTSZ2Onyh6h4Ahqc/l1t4 kVGqZ6svjpDUl/nEevvLYEywW6BCVr/GINOJ4hqJcQkcYSuMy5q+JFl8z9hRf970 YkxEoN/X5uPy+gCOY7etj3uhuIq1Qq9xfQDVes++WBaSI79fghK/JXWTKJN/gnLj CkxTDw== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e01ph0c21-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 09:09:13 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-95cd546d390so369152241.0 for ; Wed, 06 May 2026 02:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778058552; x=1778663352; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/QYN4YHTbAvld9AKdLcRu1XRlvWseqFmomQUeK7fiaw=; b=DxJyOcoXjAptXqHroIsso5/qKG4WPRrDQ/XQY8ixXPCOebwqYFXEZfdnxsuJqaIpsP jz/qCQAeQZ5IZBIJah0eArY5t5JsAZwV3nW8z7dqCGUU6oFZ/k4NH7QbugYbLLEpxvCH /d7MXrMVa9exUDOOXfs5Z/v8+4L0lchQ3NiFpPRsnucMFd4rCPiyScp/Fcq+KsTBE3/O 4Yrp6js8kgnmbNkj8PHIEOj+biG2d+xF39VGuEp0iMVwfcksorLvjj75vmnfuzNYhoUD WbmFZ2M5i+DCWZp6g2c5mmwiaiTZFGOZnO4TUttf0vxOEm0SRNiSbK5PxsnU0qLgfPZQ Q3SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778058552; x=1778663352; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/QYN4YHTbAvld9AKdLcRu1XRlvWseqFmomQUeK7fiaw=; b=Vh9271Na46jZ/ZSd5Njf/5dYlLVW0oJroU/MT+gBbZQO8yd9O59O6H8L28k7JpeOKg gU7h5GYidgniZHY4tVwswG7gpt3kwig211hiADjGJxyNTQbgabp6MJyxz2HjgwQXdcdM YbA5iodmzxP/X3CVAuseMAV4ES7TJnpeWGyWjETFiXT940Dfn9eLqVVkWcK6Boz8ViQA JyP05PNCOpObIrlu9GLZAjOjQ71r7LvbE0dfXb2H8IGYxk43F7GoYYloxWQK5NQaxm4H jEQrOVebBl54Ew4ZQcTcVhv0xWx/TpxRskW64gvGNEmgsNwfbrLxr171nMAwiDMH9c2+ FXGw== X-Forwarded-Encrypted: i=1; AFNElJ+dRHHf9E/z8DLhRxS9oZNKaL8AJL6492iIOklHGE7Zr8sWUPikLbtaKZw7YXxbEKDnIMfx7sHnJSeZoK0=@vger.kernel.org X-Gm-Message-State: AOJu0YxttCYai/HCdy1Jn4fAmbD0Bw0qlyg2dWLdOuV/MEHUvLJBOzQV 2fvKObze/xxQ1t6avMY5JkDatrVHe8t2K/g9kBO5Oihn8RMAeUyJg4hPLN1vOOX9yvx6Xsae/gM ruJuxFu6fgMOcDgvLjLbggiNaMXoXEorAnN+1mp4Y1IJaFinnhWK9t1JcK6+KRclNY4E= X-Gm-Gg: AeBDietImjLnijLBnHqy7gztyyKAj4V1sdtb0oOEP6jlHIAcyE5MT8/y5CgLWmmC/gl 5L5WL5nCls14EMW/64CGHMHjgJt3JwUl794ozmYNuRACZe4Ocbz6POkddXCCrAUaW+Nq2/l1COV Yntme6bLPffKjhxfr1RoMLdON0Y7deD2Rkvn4z26DubQPRYPammiC9j6DFLUzVjFeIqkoItPj2+ dYtxMI/wcabrZwjrtGFAH95+xB5djC4acyRYvIZ3FjGk9hp1JYR+4IgwFQb827zoBDseVhdDxQO 7rD4OHRDKqc4jSLxWz1plrlANfO4+E75lnudP31TBGr2PlmaOxF3MPGwdVK2xVlHdOUoU23NR/w KcguevXPi/c5cgZsyaBfZbyoTzB7GgEeE7FckaMeh6zD+QI+8CZqgSAEe8Hrp9NSwnCo/qtk8nf ZMs+kfVA2TkNtOEg== X-Received: by 2002:a05:6123:5db:10b0:575:2300:9f54 with SMTP id 71dfb90a1353d-5755b2afe01mr224740e0c.1.1778058552540; Wed, 06 May 2026 02:09:12 -0700 (PDT) X-Received: by 2002:a05:6123:5db:10b0:575:2300:9f54 with SMTP id 71dfb90a1353d-5755b2afe01mr224738e0c.1.1778058552073; Wed, 06 May 2026 02:09:12 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc55b17c5e0sm59970666b.11.2026.05.06.02.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 02:09:11 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 11:09:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFT PATCH] clk: qcom: dispcc-x1e80100: Fix (possibly) dumping regmap To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel J Blueman References: <20260505152908.302097-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260505152908.302097-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDA4OCBTYWx0ZWRfX0cvChxzdkX29 E9TALyis05NOymBcQqjAW9aQAw8zc2t3COX5JA9uGHTBeg3KSfvEY3scLP9dW7jK50Fdb1w7r7G lNak5EcqU52UCYJeXuvizdAz20rykByfPF+ChBYZZWzvmYc4Jr++fTdd5EiVlHCPg8uDUp4+6ty VGsvj08JNHu0lI4m3707Vgrzok0GtL02DCEdAS4m0hpaBjQD+uifRTrF0fiH5BrYgqVdz4Oy9vn GWqR9Dqvu7lSQjiVC0bkc1QgiZk0b0Koi+2PUKTFB6P2S9ADiFovl2hsS2w9oiNu3NtG5IJLe51 IK7Ez3tXf/C1goRrm23vTaLG9YC3MAA2UDz/fOADW7L/vTwe02Uj8lD1qt6WUZmtMKNeAvWqpYQ gKuCUJXnMfqoRsfohojv56bdMacJ7kEd9S/1oby6QdoNxtVQb6+5OpxpdiXuLec3/mASkbKyC4N UbbPsahCvEO9tUwwgNA== X-Proofpoint-GUID: PlmLnMlpn26uirwL7c5vvcPKGfaGBHK5 X-Proofpoint-ORIG-GUID: PlmLnMlpn26uirwL7c5vvcPKGfaGBHK5 X-Authority-Analysis: v=2.4 cv=MYhcfZ/f c=1 sm=1 tr=0 ts=69fb0539 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=t9ty7G3lAAAA:8 a=EUspDBNiAAAA:8 a=5gz2zhOb4yTQFyCjkmAA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 a=CsAS6f0m0zARWR-uHzm3:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_03,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060088 On 5/5/26 5:29 PM, Krzysztof Kozlowski wrote: > Reading few registers at the end of the block (e.g. 0x10000, 0x10004) > might result in synchronous external abort, so limit the regmap to the > last readable register which allows dumping the regs for debugging. > > Reported-by: Daniel J Blueman > Closes: https://lore.kernel.org/r/CAMVG2su+V5fcZ9LOC0Qm3bpfnhpbmQdJackc7-RvfztDL_dajw@mail.gmail.com/ > Signed-off-by: Krzysztof Kozlowski > --- > > Not really tested, just idea based on sm8750 and datasheet/manual. Not a great explanation for a completely different SoC :P > > drivers/clk/qcom/dispcc-x1e80100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/dispcc-x1e80100.c b/drivers/clk/qcom/dispcc-x1e80100.c > index aa7fd43969f9..575ba90d2070 100644 > --- a/drivers/clk/qcom/dispcc-x1e80100.c > +++ b/drivers/clk/qcom/dispcc-x1e80100.c > @@ -1634,7 +1634,7 @@ static const struct regmap_config disp_cc_x1e80100_regmap_config = { > .reg_bits = 32, > .reg_stride = 4, > .val_bits = 32, > - .max_register = 0x11008, > + .max_register = 0xf004, /* 0x10000, 0x10004 and maybe others are for TZ */ There's some trailing registers for debugcc but we normally access those via devmem anyway Reviewed-by: Konrad Dybcio Konrad