From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933567AbdKAWug (ORCPT ); Wed, 1 Nov 2017 18:50:36 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39572 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933336AbdKAWuf (ORCPT ); Wed, 1 Nov 2017 18:50:35 -0400 Subject: Re: [PATCH 1/6] shmem: unexport shmem_add_seals()/shmem_get_seals() To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: aarcange@redhat.com, hughd@google.com, nyc@holomorphy.com References: <20171031184052.25253-1-marcandre.lureau@redhat.com> <20171031184052.25253-2-marcandre.lureau@redhat.com> From: Mike Kravetz Message-ID: Date: Wed, 1 Nov 2017 15:50:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171031184052.25253-2-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2017 11:40 AM, Marc-André Lureau wrote: > The functions are called through shmem_fcntl() only. And no danger in removing the EXPORTs as the routines only work with shmem file structs. > > Signed-off-by: Marc-André Lureau Reviewed-by: Mike Kravetz -- Mike Kravetz > --- > include/linux/shmem_fs.h | 2 -- > mm/shmem.c | 6 ++---- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index b6c3540e07bc..557d0c3b6eca 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -109,8 +109,6 @@ extern void shmem_uncharge(struct inode *inode, long pages); > > #ifdef CONFIG_TMPFS > > -extern int shmem_add_seals(struct file *file, unsigned int seals); > -extern int shmem_get_seals(struct file *file); > extern long shmem_fcntl(struct file *file, unsigned int cmd, unsigned long arg); > > #else > diff --git a/mm/shmem.c b/mm/shmem.c > index 07a1d22807be..37260c5e12fa 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2722,7 +2722,7 @@ static int shmem_wait_for_pins(struct address_space *mapping) > F_SEAL_GROW | \ > F_SEAL_WRITE) > > -int shmem_add_seals(struct file *file, unsigned int seals) > +static int shmem_add_seals(struct file *file, unsigned int seals) > { > struct inode *inode = file_inode(file); > struct shmem_inode_info *info = SHMEM_I(inode); > @@ -2791,16 +2791,14 @@ int shmem_add_seals(struct file *file, unsigned int seals) > inode_unlock(inode); > return error; > } > -EXPORT_SYMBOL_GPL(shmem_add_seals); > > -int shmem_get_seals(struct file *file) > +static int shmem_get_seals(struct file *file) > { > if (file->f_op != &shmem_file_operations) > return -EINVAL; > > return SHMEM_I(file_inode(file))->seals; > } > -EXPORT_SYMBOL_GPL(shmem_get_seals); > > long shmem_fcntl(struct file *file, unsigned int cmd, unsigned long arg) > { >