From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4B942B751 for ; Thu, 7 May 2026 14:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165262; cv=none; b=MExinkCf/aIBYFv2hcVOrGEqpVL3fGiCcmOa6P0gZ4KNAI9yEA5wlm3NAkg64EZk43nhfoMapa4zm4ClZYarujodNxH0uGecVnVi7ZEnrvmyCWK4dwBSXZsnUxslcKOLiBGnrsZKjSiI2R1+XhPx5nT3VJYi8iqHRb1oh9G/tGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165262; c=relaxed/simple; bh=kAerF4ACCgUQKgQRum9APW18B6TtSIfrqCbwyrJUnWs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tijt2EHESej8iaucK+qDX23OvJxmj+aofIxlCNUzrqiJ9A99iLQ3S25GDXFRND1w1RSGVtwpDmyCtrDxSVJxf0VViy19VVbrkeqO6+YHPcYcGUWXVU4wka3iNsa1BamNJmS5Lh6dEngcAe0QFrlGjT8CI4I3f3M/Nc13k5/KUdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WBvYNpit; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d8cTX+4k; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WBvYNpit"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d8cTX+4k" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647C5WSj1971634 for ; Thu, 7 May 2026 14:47:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /3JgrC7UvTp4naNvuXkki49ri1BHchLSl7wHWcJmTuM=; b=WBvYNpitYEcOz4On ewod5PR5zejdMaJnoxj6Sle1QDC/RM7QzQsga2phfCRCgSCYSymVwqix4rIjK6vk o1mbdTtv++XF2mIy+mMonTmkwyC5Ea+CiNX6WdDlvk0d+0KHrbWkK6ncHqHBxUjZ 6wDrUyZH2c+fg5ivjREOdW03IThkLQM9Y0s+4oB9RqvbmoeOZALjp66O2bO4vUVk IDyJb2RfzwzQ2c4bUOuoEaRIguj1ppzgbZ6L0L/rCVRmm2BM1bL+iDTRMfnUtyiX BCEdBUzeR47l/R3bwPnBfm1iIbdRx9stflqxVCP1m07dTFYRNSQ/Ahzqcz/XPF48 0wrxjw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tej8mnj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 14:47:36 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b9f5ac4e36so9923165ad.2 for ; Thu, 07 May 2026 07:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778165256; x=1778770056; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/3JgrC7UvTp4naNvuXkki49ri1BHchLSl7wHWcJmTuM=; b=d8cTX+4kwUYTe0bnTTY4UdVoZmnNCZTTv45LHW/CqLu5DyeK8DLM+u4sB1Mu7Q+Xoz XhUbgFIRasQ3pUCDFze3hKEuLJ60z+BBI/Y6rPSRtKx7QSdyV7pShhWci0b0soQbxcHM G78cEEGesZCgGhfOsWJ7bO1XznChGSQVk2q3gO33wZSbhNJKqGAKXiO1iCbmAW8sFXFH 8x4Xn2+I+i7GwPLnbsd1x9E0+0K0GutSx9Psc9SureJFtFxHtM7P9jKxyz065wphWUWr Rwe0Oln6svChxZ8aByHZ6hQ+Kpvh7Sj7FQakVCXSkpQZnhwGiPNwJaQY4GcWMYpKnotA Um9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778165256; x=1778770056; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/3JgrC7UvTp4naNvuXkki49ri1BHchLSl7wHWcJmTuM=; b=fkOfK4QOgwExGRehCExmwvUzNABgntSIM5NF0xzTy7U8QO/Ug/08v6hQvRh7iKTJip rPG+U//eeyov/LGmtvII0pAWYBlY8BvuRKwwvSAyStx1hX3d9RGBKAyO4HWZgtNNVTEt tf0nqvu9MfHC4Yj+UlCZTy/P5dqcl+h0M9y7v7DyO0z7zFGRf84m0dFZ3WCyXucfUXRl 1ASvxnz5CU/ougPFlaHAJOFarZM82aMLvMRyG3XOH+L83sd2EbpT9OjZK7aEDpA/3K0K KicfJhP5yYFQdRzep56JphOHSr2NaQIi+GtSVHXL/RHaqTNAImj2KhF5kNTIg6KEQrfc b6xw== X-Forwarded-Encrypted: i=1; AFNElJ8/zCOI4/s1g2f/I4AJbW5VSsGGtyNLln9ikpXJe1NFK3EYwWB29HhaHYgYpQJetaHpu2Cuh+kKanVPZ+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzM5cB4d5QyPAGi+zSNzjCfcPXAEhqtBUlKlhXr9ml/VFePEnLQ ZJF+Qp1+sAE8rvI04zrPseV/NDgQph8mE+z+6UhIV4IIdT6fZajaawvJOXuw5Ch4993+gMXx6wX Cn8/uIrxK8lxWA47dZ3VxHLhUYhB2RckHpRupQGT0+cQk26zEk1gKMUx8HHopqyNdfAk= X-Gm-Gg: AeBDiesbw+VX1P/WF97FrH7Z8hweUhbubLk6KcTzQo8mXDYmQ6i6Qej2gN10R8lI9kZ pWuyJbRv4jHj8pSKgnAWUXUy2U0fL3w328vjlTdjTNEz8e1dxt1RRo3cV3Gs2OKl16skQH3tQpZ hYHHE+qv99hRFkrI8YZI78WU4Ibur/h9DoGAl+Sq+jYJf15p/nY16BnDulBWw3TiINEkKxENXnf Y7h7M58tJ4QEy3XS+yReOyYuEzzXPy8QFjPyxt+FHWyiwmaCbjD9UHYZ6UUbFxetvDRbbTxgAUp WoNTqyHM1r7hManNtcYo0inL4H++lZLalr/YI/PiAO93AAIhoc7lFv7CspX+yGnNKyrf0gtEIMs k8Lxp20iWf5GSGBfOJlLRCUwdMwfF6UrqKJZd0TYaxtYcKV9y6YQuv8c= X-Received: by 2002:a17:903:2f4e:b0:2b9:ff02:a154 with SMTP id d9443c01a7336-2ba798c2792mr86545205ad.15.1778165256256; Thu, 07 May 2026 07:47:36 -0700 (PDT) X-Received: by 2002:a17:903:2f4e:b0:2b9:ff02:a154 with SMTP id d9443c01a7336-2ba798c2792mr86544885ad.15.1778165255667; Thu, 07 May 2026 07:47:35 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babaac34a4sm31666325ad.16.2026.05.07.07.47.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 07:47:35 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 20:17:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 17/29] drm/msm/adreno: set fp16compoptdis for UBWC 3.0 formats To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-17-c19593d20c1d@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260507-ubwc-rework-v4-17-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDE0OCBTYWx0ZWRfX/rJjpeDfMky8 RMpmLmUXtbz9nO5Z3xkZSF+o0wsJ+8PCIjWG6J9n+6clGhn2yKmTLEs6SqQjkdd0M4qZuceVPtX BlCuiXuJV4CvYAQoHHgOePsws7sbqEhxHoto+9hZPn1tniB6hOnmn7h6sdXIIRixkVJAmqcLtZs ZtxDAr/NHqclj5kAZJ5aBns/zHSP8PTeHvaBbf8kCKDafDLue31OnDVopsziXhMpUzYNO/b1f9J lQvagB38MJabtNfk5ON+RU7Pwk44iWzowUcEn0qTYf7uCJq3YXFxf7eiyctyqIUqPJCSSYfBGVb /LbfuIXTboNusiElC9lMB4Q2KMJROC9rvRy/0Vb8EnDmIUfCtIjo9bVG/S7AwRiH/VHRRddgMLg 6mv9p0BMPTZmtiELgDAOeSqTfOV7Dzx462oXG10hloevQRjewLoY9+ZHPFD9+yxDAks9fsnUi2C BMT5Bc1t/SdZX7WJnSw== X-Proofpoint-GUID: H7IEkG3KIM8kThRLIPoJh-2UFsHBwbJ6 X-Authority-Analysis: v=2.4 cv=VNbtWdPX c=1 sm=1 tr=0 ts=69fca608 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=4tzv1H2Sf9v1fZNdEqgA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: H7IEkG3KIM8kThRLIPoJh-2UFsHBwbJ6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070148 On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote: > The fp16compoptdis bit should be set if the system targets UBWC 3.0 > format in addition to UBWC 4.0. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index 7a6223ddd8cf..867c7d05f670 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -303,6 +303,7 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > break; > case UBWC_3_0: > amsbc = true; > + fp16compoptdis = true; > break; > default: > dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); >