From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01FBC2BA18 for ; Mon, 6 Apr 2020 04:51:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CC47206C0 for ; Mon, 6 Apr 2020 04:51:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="EE21H0uW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbgDFEvj (ORCPT ); Mon, 6 Apr 2020 00:51:39 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:45226 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgDFEvj (ORCPT ); Mon, 6 Apr 2020 00:51:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586148698; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=XqOVPv1elEVhl7owP6ToQ1u/b9NrcPBlIL+fC4WITPo=; b=EE21H0uWgnAl6/KllP+ia3WuJf79NkiYmPdUBmbFwl7pt/stDrmdL3Ck86WTlTvoSUrRbML0 DTYTVPCXy39AN49sgEkinHG9dMg1GCvgPA0lH2Fr40YTbsunK6+WDJWVncfZWqLpsvkk2LgS +zXKlYqljDfWcHUu8OC4UsG9/Es= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8ab559.7fee662c65e0-smtp-out-n02; Mon, 06 Apr 2020 04:51:37 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4D254C43637; Mon, 6 Apr 2020 04:51:37 +0000 (UTC) Received: from [192.168.43.137] (unknown [106.213.172.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mkshah) by smtp.codeaurora.org (Postfix) with ESMTPSA id 12DA5C433F2; Mon, 6 Apr 2020 04:51:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 12DA5C433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=mkshah@codeaurora.org Subject: Re: [PATCH v15 5/7] soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches To: Doug Anderson Cc: Stephen Boyd , Evan Green , Bjorn Andersson , LKML , linux-arm-msm , Andy Gross , Matthias Kaehlcke , Rajendra Nayak , Lina Iyer , lsrao@codeaurora.org References: <1585660782-23416-1-git-send-email-mkshah@codeaurora.org> <1585660782-23416-6-git-send-email-mkshah@codeaurora.org> From: Maulik Shah Message-ID: Date: Mon, 6 Apr 2020 10:21:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/3/2020 1:43 AM, Doug Anderson wrote: > Hi, > > On Tue, Mar 31, 2020 at 6:20 AM Maulik Shah wrote: >> +/** >> + * rpmh_rsc_ctrlr_is_busy: Check if any of the AMCs are busy. > nit: this is still not quite kerneldoc format. Specifically, the > above should be: > > * rpmh_rsc_ctrlr_is_busy() - Check if any of the AMCs are busy > > You may think I'm being nit picky, but try running: > > scripts/kernel-doc -rst drivers/soc/qcom/rpmh-rsc.c > > Now search the output for "Check if any of the AMCs are busy". It > won't be there as you have formatted it. If you fix it to the proper > format then it shows up. I'm not saying that you should fix up all > functions at once but if you're adding new functions why not make them > compliant? > > > Other than the kerneldoc nitpick which could happen later in a cleanup > series for the whole driver at once, this patch looks fine to me now. > > Reviewed-by: Douglas Anderson Thanks for the review Doug. I will fix this in v16 to update as per kernel doc format. Thanks, Maulik -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation