From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56FE190477 for ; Wed, 22 Oct 2025 05:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761112567; cv=none; b=rqHSWIxPScXjogwGxSNnW3Kdy5lDp834Pg8XyLaFYFIrVGJdGVZFGktGQ4pI2Og0KipG7mU4k0fqsfgYAvCseoLuZlAev8ipndtYFh7Ar/nyiHQmPTIWgrZGASjQ9HOuf5xiuHCM1Ky9X1m5mU3jPizYcTfIEEPl37P+h5y49/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761112567; c=relaxed/simple; bh=CAE35DJcjLYj2/oXjadiEL4ZX4qY39eziNS80KbwbhQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i7MQIXyHmcUce/c9CiPKFNGNzBvtdYKwJYn9ClNcQ8/s6rcX5Ha9jRNEsSR4X+BWJKBe2m/fYoaHSUdmlmZIqC4/rv+PGcZFDBDWO+ZCl9jKpR2Jp2p1hxdHxgAl3Jm71kst+5LBGklhtQcoWg5U9ZMUP2r7aegC6ONvEQSLp38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Ejh+DcD0; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Ejh+DcD0" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761112548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O9v8uzOZ2BjUR4zUy5fKDZn7QBtnMzhYGRU6pZ93UAA=; b=Ejh+DcD0uofz+F23p0ULeC77nHIN/vp21YzT60jryIE4l8GESqxhtAu34b8BgLXWpY4sm8 o4oKr4BAgfztUEre4kEVoSMtxjKqy+CjKP+AwYMU4R3i7CyqJmLGkTGYQRKHpkhrqzSn6K yAxjIAR7QiSuXEn6F1hY1FrhWJRYLX0= Date: Wed, 22 Oct 2025 13:55:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 13/22] smb: move file access permission bits definitions to common/cifspdu.h To: Namjae Jeon Cc: stfrench@microsoft.com, metze@samba.org, pali@kernel.org, smfrench@gmail.com, sfrench@samba.org, senozhatsky@chromium.org, tom@talpey.com, pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, bharathsm@microsoft.com, christophe.jaillet@wanadoo.fr, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251014071917.3004573-1-chenxiaosong.chenxiaosong@linux.dev> <20251014072856.3004683-1-chenxiaosong.chenxiaosong@linux.dev> <20251014072856.3004683-3-chenxiaosong.chenxiaosong@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: ChenXiaoSong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Should we move all file access permission bit definitions to common/cifspdu.h? Perhaps in the future we can change them to be the same. On 10/20/25 1:27 PM, Namjae Jeon wrote: >> + >> +#define CLIENT_SET_FILE_READ_RIGHTS (FILE_READ_DATA | FILE_READ_EA | FILE_WRITE_EA \ >> + | FILE_READ_ATTRIBUTES \ >> + | FILE_WRITE_ATTRIBUTES \ >> + | DELETE | READ_CONTROL | WRITE_DAC \ >> + | WRITE_OWNER | SYNCHRONIZE) >> +#define SERVER_SET_FILE_READ_RIGHTS (FILE_READ_DATA | FILE_READ_EA \ >> + | FILE_READ_ATTRIBUTES \ >> + | DELETE | READ_CONTROL | WRITE_DAC \ >> + | WRITE_OWNER | SYNCHRONIZE) >> +#define CLIENT_SET_FILE_WRITE_RIGHTS (FILE_WRITE_DATA | FILE_APPEND_DATA \ >> + | FILE_READ_EA | FILE_WRITE_EA \ >> + | FILE_READ_ATTRIBUTES \ >> + | FILE_WRITE_ATTRIBUTES \ >> + | DELETE | READ_CONTROL | WRITE_DAC \ >> + | WRITE_OWNER | SYNCHRONIZE) >> +#define SERVER_SET_FILE_WRITE_RIGHTS (FILE_WRITE_DATA | FILE_APPEND_DATA \ >> + | FILE_WRITE_EA \ >> + | FILE_DELETE_CHILD \ >> + | FILE_WRITE_ATTRIBUTES \ >> + | DELETE | READ_CONTROL | WRITE_DAC \ >> + | WRITE_OWNER | SYNCHRONIZE) > What's the reason for moving it if the smb client and server don't share it? -- Thanks, ChenXiaoSong.