From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Matthew Sakai <msakai@redhat.com>,
"J. corwin Coburn" <corwin@hurlbutnet.net>,
Sweet Tea Dorminy <sweettea-kernel@dorminy.me>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@lists.linux.dev, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: dm vdo slab-depot: delete unnecessary check
Date: Sun, 11 Feb 2024 19:29:28 +0100 [thread overview]
Message-ID: <bc60c33e-c268-4e7e-94f9-e573545ffe98@web.de> (raw)
In-Reply-To: <16ffd614-48a9-42b8-961d-2dc8a69c48d6@moroto.mountain>
> This is a duplicate check
Was this implementation detail detected with any known source code analysis tool?
> so it can't be true. …
I suggest to reconsider this information a bit more.
Would you usually expect the outcome “result == VDO_SUCCESS” from a call
of the function “uds_allocate”?
Regards,
Markus
next prev parent reply other threads:[~2024-02-11 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 13:06 [PATCH] dm vdo slab-depot: delete unnecessary check Dan Carpenter
2024-02-11 18:29 ` Markus Elfring [this message]
2024-02-11 18:55 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc60c33e-c268-4e7e-94f9-e573545ffe98@web.de \
--to=markus.elfring@web.de \
--cc=corwin@hurlbutnet.net \
--cc=dan.carpenter@linaro.org \
--cc=dm-devel@lists.linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msakai@redhat.com \
--cc=snitzer@kernel.org \
--cc=sweettea-kernel@dorminy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox