From: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock
Date: Mon, 26 Sep 2016 10:54:52 +0200 [thread overview]
Message-ID: <bc80fe0a-8a9f-a597-8f8b-e7875302b337@collabora.co.uk> (raw)
In-Reply-To: <20160926081841.7jmvdto2ht23rdw6@pengutronix.de>
Hi,
On 26/09/16 10:18, Sascha Hauer wrote:
> On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote:
>> This binding allow to disable the internal 60Mhz clock for USB host2 or
>> host3.
>>
>> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
>> ---
>> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
>> drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++
>> drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
>> drivers/usb/chipidea/usbmisc_imx.c | 13 +++++++++++++
>> 4 files changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> index 0e03344..f83da66 100644
>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> @@ -84,6 +84,7 @@ i.mx specific properties
>> - over-current-active-high: over current signal polarity is high active,
>> typically over current signal polarity is low active.
>> - external-vbus-divider: enables off-chip resistor divider for Vbus
>> +- disable-int60ck: disable internal 60MHz clock for usb host2 or host3 on imx53
>
> Why do we need a binding for this? I would assume the driver should know
> whether this clock is in use or not. If it doesn't that's a problem we
> should solve.
>
Yes you are right because we can disable this clock for OTG and with
ULPI PHY. I think that it will be better to have a dt binding but if it
is useless I can remove it and disable clock when ULPI mode is enabled.
> Sascha
>
Fabien
prev parent reply other threads:[~2016-09-26 8:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 9:07 [PATCH v5 0/2] usb: chipidea: imx: Add USB configuration for imx53 Fabien Lahoudere
2016-09-21 9:07 ` [PATCH v5 1/2] usb: chipidea: imx: configure imx for ULPI phy Fabien Lahoudere
2016-09-21 9:07 ` [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock Fabien Lahoudere
2016-09-23 19:47 ` Rob Herring
2016-09-26 9:00 ` Fabien Lahoudere
2016-09-26 8:18 ` Sascha Hauer
2016-09-26 8:54 ` Fabien Lahoudere [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc80fe0a-8a9f-a597-8f8b-e7875302b337@collabora.co.uk \
--to=fabien.lahoudere@collabora.co.uk \
--cc=Peter.Chen@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox