From: Igor Russkikh <irusskikh@marvell.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
<davem@davemloft.net>, <kuba@kernel.org>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [PATCH v2] net: atlantic: Avoid out-of-bounds indexing
Date: Fri, 8 Apr 2022 16:38:58 +0200 [thread overview]
Message-ID: <bc8d25ed-e65f-83b9-e21c-25150f9b8884@marvell.com> (raw)
In-Reply-To: <20220408022204.16815-1-kai.heng.feng@canonical.com>
> UBSAN warnings are observed on atlantic driver:
> [ 294.432996] UBSAN: array-index-out-of-bounds in
> /build/linux-Qow4fL/linux-5.15.0/drivers/net/ethernet/aquantia/atlantic/aq
> _nic.c:484:48
> [ 294.433695] index 8 is out of range for type 'aq_vec_s *[8]'
>
> The ring is dereferenced right before breaking out the loop, to prevent
> that from happening, only use the index in the loop to fix the issue.
Thanks,
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Igor
next prev parent reply other threads:[~2022-04-08 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 2:22 [PATCH v2] net: atlantic: Avoid out-of-bounds indexing Kai-Heng Feng
2022-04-08 14:38 ` Igor Russkikh [this message]
2022-04-09 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8d25ed-e65f-83b9-e21c-25150f9b8884@marvell.com \
--to=irusskikh@marvell.com \
--cc=davem@davemloft.net \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox