From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F32C77B6E for ; Sat, 8 Apr 2023 14:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbjDHOFP (ORCPT ); Sat, 8 Apr 2023 10:05:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbjDHOFK (ORCPT ); Sat, 8 Apr 2023 10:05:10 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3C2DEFBF for ; Sat, 8 Apr 2023 07:04:46 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id m4so1268589lfj.13 for ; Sat, 08 Apr 2023 07:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680962644; h=content-transfer-encoding:in-reply-to:from:cc:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0WL9vzgqqE2pipTqBiWSrHFHOR0gA/wvhMKbIOyTCx4=; b=C4Y5hVQjqEdbrAgl7ddcR/G0CTn2R+5G87TZqUdANJ6cDohv0VlIiHfjLHEaWs+20C TITuRzNrRPRfaARxlRAt7dl9dRygEkfXjn+0fg+KqDDdgWh9BOySv2X2WlpOC8z77Kfv lNyTD9LDzt6SeLmXv/W9UDNfQdxEAEtRy/kRZiVzmxjSbTKz+0VyfA7L6pIxfKDPm/zh j94ffehdatEumnX+ycF5E1iKYO8akOUm5P26Q4cVtLA6Zp8eHarsN83MhNYCJwgIkmaS 0BmNi/3N9YCjXDhyfauTc0jDSL5ic9zzrLuw+hmVD0ulZUoKQivcoL81fwdCu5Z/p+FC IWxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680962644; h=content-transfer-encoding:in-reply-to:from:cc:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0WL9vzgqqE2pipTqBiWSrHFHOR0gA/wvhMKbIOyTCx4=; b=2BnYfLsq4ZV8gvmbKYwy1NM7/GWgf2/kg+K6JLwvcx0w1q7E+kTlhHNF7UxI2rlbZ3 t8vgDaQLlv4Jo6NAJ03CJk1hKDTFfzU0hsTA9kfG6mG5WzMpDp/rBrKln/4bfftdAYLh dHUZRt49zb6lyi914a4N/9FSlyuk93L7W0ltOf1tde+6hvoQOU8Yvj0ZO5T8vSu1DAUl YoiS15HdUhVfSFxBr3egrjukLkTUgiKQArzYfE8SSpgZdmClMn5QqZzlc25S5qj40IGn oM95h1qq30MuLcPx3e9GzRMAeV+ZFoJXt+8xsfc1IWf0w6pIFQzJfZzYc1nGDu9TvOhD 6OTA== X-Gm-Message-State: AAQBX9dLrfEhVYGOT0KG0gTW61gous7e0t5SS3lRVfZma19IonW5ZUv6 rRuSTwABR8ejHzCTQx7FbBtBoQ== X-Google-Smtp-Source: AKy350bV4sNPKiPwg9ZiG94yR3Evq5nlRIX3s92+bjKr+Q/6psvEe1ZIJEos7fo6yRMvL3+InOltMw== X-Received: by 2002:a19:f50a:0:b0:4a4:68b9:1a14 with SMTP id j10-20020a19f50a000000b004a468b91a14mr462139lfb.60.1680962644275; Sat, 08 Apr 2023 07:04:04 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id y9-20020ac255a9000000b004eb2d6160a4sm1193749lfg.32.2023.04.08.07.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Apr 2023 07:04:03 -0700 (PDT) Message-ID: Date: Sat, 8 Apr 2023 16:04:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 3/3] dt-bindings: clock: qcom,gcc-sc7280: document CX power domain Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Taniya Das , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230408134820.76050-1-krzysztof.kozlowski@linaro.org> <20230408134820.76050-3-krzysztof.kozlowski@linaro.org> Cc: Rajendra Nayak From: Konrad Dybcio In-Reply-To: <20230408134820.76050-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8.04.2023 15:48, Krzysztof Kozlowski wrote: > The GCC clock controller needs CX power domain, at least according to > DTS: > > sc7280-herobrine-crd-pro.dtb: clock-controller@100000: Unevaluated properties are not allowed ('power-domains' was unexpected) > > Signed-off-by: Krzysztof Kozlowski > --- +CC Rajendra Same question as with 7180 Konrad > .../devicetree/bindings/clock/qcom,gcc-sc7280.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml > index 947b47168cec..ff0b18bbb0fc 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml > @@ -43,6 +43,10 @@ properties: > - const: ufs_phy_tx_symbol_0_clk > - const: usb3_phy_wrapper_gcc_usb30_pipe_clk > > + power-domains: > + items: > + - description: CX domain > + > required: > - compatible > - clocks > @@ -56,6 +60,8 @@ unevaluatedProperties: false > examples: > - | > #include > + #include > + > clock-controller@100000 { > compatible = "qcom,gcc-sc7280"; > reg = <0x00100000 0x1f0000>; > @@ -71,6 +77,7 @@ examples: > "pcie_1_pipe_clk", "ufs_phy_rx_symbol_0_clk", > "ufs_phy_rx_symbol_1_clk", "ufs_phy_tx_symbol_0_clk", > "usb3_phy_wrapper_gcc_usb30_pipe_clk"; > + power-domains = <&rpmhpd SC7280_CX>; > #clock-cells = <1>; > #reset-cells = <1>; > #power-domain-cells = <1>;