From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6D73EBF04 for ; Thu, 23 Apr 2026 12:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776948922; cv=none; b=AKeZqipjpTcmdbla3gLDtdoq91nMqLdIQDcwMskIWE2v/fm/EoTcRcd80FmCGYVjvS0+TDFvOLeeoG811B8ObsLpD78du9PRpKayEM7sB0vKVmjue+ytjjYPQTnlirRGKM/hXQntVxXvHnGyHO5HqdxTmO1Lrbi0nE713s1ZX+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776948922; c=relaxed/simple; bh=/U0+AhQjNBpLSjc2P7sqUUfBZy0Jicg5NVul6rhY7lU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O07xKUUL5jJ4GdMHJ5QdlbXCMBgEe+h6OIbm50Nnhfb9Cn7EqNGoPjmZogNNh24TR1ooZLXL7Mw8ZsVL6w1GgK9BjMLxwbALzvD9MyRYWT5H7BxvqlOcvKCoH+w+6j6dnOvZDwRzo8N3xbLoo+7jj61LrxUFrzNaUmgPzjHw8bE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JCK8kuJG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SM7XqsVM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JCK8kuJG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SM7XqsVM" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uEau3044055 for ; Thu, 23 Apr 2026 12:55:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /U0+AhQjNBpLSjc2P7sqUUfBZy0Jicg5NVul6rhY7lU=; b=JCK8kuJG83gIw3u9 oSOAIgGzun4EEOKmLc1QIVbqF1hZhnBbJcVSzA7jeWZoIvrCokLBJsZn7Ybk9qhB y+ocaT9L4cfGgH1vrt4YbZZrUlF4byasAQXuuZ1XNCp+o4eQfI62TZjm2QhOaIOX BEY8PzPrkF01eg4Vl6yYiK4/VfIj8QwBzJjjfrC5wVE1APYn76/E2HAoOCRCE9xi wiH62URsEKjawnF9gvYwzD1kWddyjmQNhl4FGtxKH+6uLZFvn519RrFu/elJrj6e Ir6i+aQk6JBVWdwXJ7661uXayMMJek67U46s13agfM573CnJnUNm36x/40iILIU5 eXohAQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh3y11-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:55:20 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b7a77b8ec9so6354925ad.3 for ; Thu, 23 Apr 2026 05:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776948919; x=1777553719; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/U0+AhQjNBpLSjc2P7sqUUfBZy0Jicg5NVul6rhY7lU=; b=SM7XqsVMeGA5g40uUVQFWDKlmWBKEgvMQBRqj3vfIWgrxJ3VQxNSXwkq3GwSVexfF+ hoaARL6E2CUl6kVUL0E9CBAaosHniuJT/wDOoUTfvBvSh3MoOgaZqPbWKa1a6ScQo1fg I5C3dXM4b0ab36/4bHPuBlCFnNpTLUIimeq8s6w/sOWDSEFomOjum8yyvKm9RZEYT1vq 88l8T4XUsO6fKX9bcMQYR3fGkrxu3CTtbBIraDDwchqLYuEvfLK/9xExwJkzdy+6iNCA 5rp8lLZGt+1UHX75psg0YMqUN/QGrmjzoZwU1Aj/09vp6IL32azhjZKuMBEjTFMGp1Lf +kcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776948919; x=1777553719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/U0+AhQjNBpLSjc2P7sqUUfBZy0Jicg5NVul6rhY7lU=; b=tRIdUSld97F8Uq0aLTblLeQD+WGPhqThCdCmmXBhxGryub+DGkn9cuAP384mTQIejz fXLEmNXmL8/j7b7LX2AXNGZmXyHZLA5jSOqZGZ0/tqSXRnvW9LBsaNVJphJahDZ4305T POfu97EHVI6ouJ+1Bvs0pexcnfTbWo1Y3dl8rvmFHlAtH19S/Bl+LAnCa9gAzkm+6BEc DBSyuRBaD6YLC6hGeK88qSY9gzJYQLiIlrpcjxMfjaaypEIGITIIQ+CG0EKVPwG/yIr1 09Ffu56TbKToHTYuJm2PQK4lQNeLag+uPAD9vyPHepqrXzD+pNh0kgm43ia3fUc3SPMn YtJw== X-Forwarded-Encrypted: i=1; AFNElJ8H+GpCOaHW82Er4P89QirA+PPnrrOUHyMYjGVwjKdjTplF4sPp+a4wlQD7eRbgQbX+vfYPXefUGNjRBJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YwH9sUhuIWCjT/+mJCNhDSc8VgBBv7/etT+4CKncgPHmnhrFYd6 cC1K+mNd5yy3PbvGv7i71QK3zuTTqkXqIGyZujtrBkt+4fyROoaMF7HTGXzDX44Cm+MECtnM77b tVol061UvKXuo6uUhk3dEGPMnMeD9uQVst5hJp53HOH7GKDkYWLbOvNnbYFTfyE1DBMg= X-Gm-Gg: AeBDieu7Cn+iYnkbkVUOyFoo5aCKgPNTPm66YwKU57lJJmpR9yTuaaNa2LkXpSUodqX JtU3AhrBq4mosZuCQWiFN245AzlGaHwL68F+c69H3ceobEF/H2REF/qi76FFOl1L1gkJxTMO9Wu i5UzAb3zkZyNcJIWinsaI426vI0/BR9XuoK6U44leHFsMTc939v6AdSyc8E25z0UFxeD5H6z8tP DgSj5Mdii7FfLDf3mDeDui4LgX2RBR/94D+44FUT8S62oivBCnJTGr7/e93pp6eRXIGYCEkW3Kg cYTY93TBdiW3Kkjrwg2Yw9gN6gYneGA05JPU+DND97yiwbIg5cUmRPtlawdqmy1K8A+Wfdik8yd F0fPSLsi/QBmPvncoya7BrIB0pmclvO4SsHTTARuddCqohkxjrA1L8MBgqXW8ZOSkYzAbezfESt UlOVz1Ns6BEI9qtaJTTYHK X-Received: by 2002:a17:903:1a85:b0:2b7:a89d:6135 with SMTP id d9443c01a7336-2b7a89d6531mr25581545ad.13.1776948919145; Thu, 23 Apr 2026 05:55:19 -0700 (PDT) X-Received: by 2002:a17:903:1a85:b0:2b7:a89d:6135 with SMTP id d9443c01a7336-2b7a89d6531mr25580985ad.13.1776948918657; Thu, 23 Apr 2026 05:55:18 -0700 (PDT) Received: from [10.133.33.37] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0c17esm191810585ad.41.2026.04.23.05.55.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 05:55:18 -0700 (PDT) Message-ID: Date: Thu, 23 Apr 2026 20:55:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() To: hoyoung seo Cc: James.Bottomley@HansenPartnership.com, adrian.hunter@intel.com, alim.akhtar@samsung.com, avri.altman@wdc.com, beanhuo@micron.com, bvanassche@acm.org, chullee@google.com, huobean@gmail.com, keosung.park@samsung.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, liu.song13@zte.com.cn, mani@kernel.org, martin.petersen@oracle.com, peter.wang@mediatek.com, rafael.j.wysocki@intel.com, ram.dwivedi@oss.qualcomm.com, tanghuan@vivo.com, vamshigajjela@google.com, kwangwon.min@samsung.com, kwmad.kim@samsung.com, cpgs@samsung.com, h10.kim@samsung.com References: <1891546521.01776810002507.JavaMail.epsvc@epcpadp1new> Content-Language: en-US From: Can Guo In-Reply-To: <1891546521.01776810002507.JavaMail.epsvc@epcpadp1new> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEyNyBTYWx0ZWRfXxvACia03S+Z/ do1+/YARIPs+GCtlvv75+zVZDbuqrAywdm949uu8WLy97kt1NpSl651JH+oKKxdv6BV1IC+J0Ll Tn3mzERieVlMfjTNM9m5zObKMyzV7HNISZyY0lm8QJrcHmx148GTnqO513FpfE8y1RhH9QRlNcs OoQ2HYD1WMyDqyrQWxaJ7aE2EX76pZdxOboTR+7q539hHc9z8Y/I1tSZzsVwLYFDxkvqM3zpOqW puFzibDHJgNIBQbzLLsAkRr8mMpOEVCorBU9KayCyse2CNFuKVZvNvu0oyyUwrJsjWLWs+lG+H9 EPrgiy5e3NqhkQDYmeXeT2yzoVHPGByvMcjHXO12F9UdNPz1gei3Pzf+qZwgrvrgchrHxXxNTO6 BtDZ3/VYwoGTMxPO1ew14jCvRpkJp1JMYjKmWzv+CI1nE11zyd/jBn77+2tE9i2apI2U6dYJIV7 8KX6FXWrej7OqdAsABg== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69ea16b8 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=9uCRR3fI0jiCCddHergA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: fZClpC5KfiAl-3sS2GLS7vzv0OAXSwmP X-Proofpoint-ORIG-GUID: fZClpC5KfiAl-3sS2GLS7vzv0OAXSwmP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230127 Hi, On 4/21/2026 7:01 PM, hoyoung seo wrote: > Hi, > > How about you to add EXPORT_SYMBOL at ufshcd_query_attr_qword() function. > In the case of ufshcd_query_attr(), there is export_symbol so it can be used in vendor driver. > Likewise, if export_symbol is registered in ufshcd_query_attr_qword(), it can be used in the vendor driver and the pair will be correct. One should export a symbol only if there is a module *really* using it... Thanks, Can Guo. > > Thanks. > > SEO. > >