The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Barnabás Czémán" <barnabas.czeman@mainlining.org>
To: david@ixit.cz
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bryan O'Donoghue <bod@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH] remoteproc: qcom_q6v5_mss: Save the need_pas_mem_setup into qproc
Date: Sat, 21 Nov 2026 14:04:26 +0100	[thread overview]
Message-ID: <bca16109c94e7bd5fc057cca895ec50f@mainlining.org> (raw)
In-Reply-To: <20261117-qcom_q6v5_mss_msm8953-v1-1-0fdaea2855ff@ixit.cz>

On 2026-11-17 20:51, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> On hardware requiring Peripheral Authentication Service (PAS) for modem
> memory setup (e.g., SDM632), the remoteproc subsystem skips hardware 
> memory
> authentication because q6v5_probe() fails to copy the 
> need_pas_mem_setup
> flag to the allocated device instance.
> 
> Original commit didn't save the value into the structure thus quietly
> skipping if (qproc->need_pas_mem_setup) condition.
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: 
> https://sashiko.dev/#/bug/linux-83fcbc28-236c-48e4-a6bd-731f4361f9ae
> Fixes: f56052f4d87c ("remoteproc: qcom_q6v5_mss: Introduce 
> need_pas_mem_setup")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c 
> b/drivers/remoteproc/qcom_q6v5_mss.c
> index dd052a62b8583..5d084aa2eac36 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -2189,16 +2189,17 @@ static int q6v5_probe(struct platform_device 
> *pdev)
> 
>  	qproc->has_alt_reset = desc->has_alt_reset;
>  	ret = q6v5_init_reset(qproc);
>  	if (ret)
>  		goto detach_proxy_pds;
> 
>  	qproc->version = desc->version;
>  	qproc->need_mem_protection = desc->need_mem_protection;
> +	qproc->need_pas_mem_setup = desc->need_pas_mem_setup;
>  	qproc->has_mba_logs = desc->has_mba_logs;
> 
>  	ret = qcom_q6v5_init(&qproc->q6v5, pdev, rproc, 
> MPSS_CRASH_REASON_SMEM, "modem",
>  			     qcom_msa_handover);
>  	if (ret)
>  		goto detach_proxy_pds;
> 
>  	qproc->mpss_perm = BIT(QCOM_SCM_VMID_HLOS);
> 
> ---
> base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
> change-id: 20261117-qcom_q6v5_mss_msm8953-aba81523223b
> 
> Best regards,
> --
> David Heidelberg <david@ixit.cz>

Thanks, i have tested the patch on Redmi S2 (MSM8953).

Tested-by: Barnabás Czémán <barnabas.czeman@mainlining.org>

      reply	other threads:[~2026-11-21 13:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 19:51 [PATCH] remoteproc: qcom_q6v5_mss: Save the need_pas_mem_setup into qproc David Heidelberg via B4 Relay
2026-11-21 13:04 ` Barnabás Czémán [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bca16109c94e7bd5fc057cca895ec50f@mainlining.org \
    --to=barnabas.czeman@mainlining.org \
    --cc=andersson@kernel.org \
    --cc=bod@kernel.org \
    --cc=david@ixit.cz \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox