From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756780AbdEKQVV (ORCPT ); Thu, 11 May 2017 12:21:21 -0400 Received: from mout.web.de ([212.227.15.14]:56289 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753354AbdEKQTy (ORCPT ); Thu, 11 May 2017 12:19:54 -0400 Subject: [PATCH 4/4] vmbus: Adjust five checks for null pointers From: SF Markus Elfring To: devel@linuxdriverproject.org, Haiyang Zhang , "K. Y. Srinivasan" , Stephen Hemminger Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Thu, 11 May 2017 18:19:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:JilQO+GG4ubirAYbxWIC89QrrlQ2bKEutGUhcON4g7Tq7/hPsWT xABGilzu85F7Aj0cMc4V7P7/HeSa3doUhfeHoszmIxQXQcR49gkcwQnyQqKaQ5PZyRAL7Qo fsrWTWfo4wffnW6zH708wBUfiyJGv1IkKARhs+9IqGwPMz2rYywCcF+fq4sgyYRm1R1Woc4 iTou8n/oJ7U5JEn2nFJjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:aqENWlZlK5w=:fR6OA15o4LihiNtCOBG61y TA5PK8Vm6TJNKzHkTxe9h05wLc/yLSo4h+PJfZfP/RDsDoEsD6UR7vREhoasNrZnD9u+kjgrK k4VfMMBwoqOhhUjP+kCeeL7+BFeX03bX3tXX+Wq7JqQT56dUpIU3reN26zaH1t1WkEoaV38Ot nI8Xu8Nt7t7y0GU+gP6wDdiIQnJGwr7UakcMKgsItx2rj0+7CPNSepynPeKG55H0oHMHPVav0 WP1nx7HBJCJ4MxurO90I5APkzmg/mRHu3xnvDJ3ipFzV4a9komc2Uoidj6wLNKKv8pZIY89If LRgNaCgO3Ykxtnzfh/sXA/Mnrm83JriHa0C121exRFcCLuvw5jgTbix1uZV3cMYln4b1R1Bkn TU7SV+4U3qU0j/8cH3K4ps61ztzuoLyJdsyL8TfWDFakS4OstrlDYZnr+DIyG5zLUrLkGBhmG LNqhf7TTbip45b6z4t8d1fUfD2qX5bHyqZYoA7FPR9harG28QK8u0c4Qc9OVWjB00yjElEbSW kpYFdf/0wW0BwirJHDRYT459E1dXUrg7x74vn4ooSki3+FB9MPnR+hdHHluEPeEk1ObPBI/eq 2De1AzqaDZPV8HLQL9uY6k2IaGAQNturS55HLwQcNPnojg8rFR8ahD+1Dt/SdGy4WjiiTeCMk adW4x08UifScJanmTsmQFiQAkW5QDQEF3NmXSWSogAuKP7xYNY1QdISjuPWP00iPDl2QFZnUA PrGsFQGCjBT8zeY5gQHwqT2MvNxJPehBcD/p9Y/HqpazoHS8gex6IVg0/qU/fppUrRef0A3Rx 11ypRZv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 11 May 2017 17:52:38 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/hv/vmbus_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index ff94b111ed8d..b55b979ecf8a 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -93,7 +93,7 @@ static DEFINE_SEMAPHORE(hyperv_mmio_lock); static int vmbus_exists(void) { - if (hv_acpi_dev == NULL) + if (!hv_acpi_dev) return -ENODEV; return 0; @@ -568,7 +568,7 @@ static const struct hv_vmbus_device_id *hv_vmbus_get_id(struct hv_driver *drv, return id; id = drv->id_table; - if (id == NULL) + if (!id) return NULL; /* empty device table */ for (; !is_null_guid(&id->guid); id++) @@ -871,7 +871,7 @@ void vmbus_on_msg_dpc(unsigned long data) entry = &channel_message_table[hdr->msgtype]; if (entry->handler_type == VMHT_BLOCKING) { ctx = kmalloc(sizeof(*ctx), GFP_ATOMIC); - if (ctx == NULL) + if (!ctx) return; INIT_WORK(&ctx->work, vmbus_onmessage_work); @@ -894,7 +894,7 @@ static void vmbus_channel_isr(struct vmbus_channel *channel) void (*callback_fn)(void *); callback_fn = READ_ONCE(channel->onchannel_callback); - if (likely(callback_fn != NULL)) + if (likely(callback_fn)) (*callback_fn)(channel->channel_callback_context); } @@ -970,7 +970,7 @@ static void vmbus_isr(void) union hv_synic_event_flags *event; bool handled = false; - if (unlikely(page_addr == NULL)) + if (unlikely(!page_addr)) return; event = (union hv_synic_event_flags *)page_addr + -- 2.12.3