From: Chao Yu <chao@kernel.org>
To: "yohan.joung" <yohan.joung@sk.com>,
jaegeuk@kernel.org, daehojeong@google.com
Cc: chao@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, pilhyun.kim@sk.com
Subject: Re: [PATCH v5 2/2] f2fs: add ckpt_valid_blocks to the section entry
Date: Mon, 12 May 2025 16:32:40 +0800 [thread overview]
Message-ID: <bcb59f9d-a908-4ea4-ba24-af4cfa54145b@kernel.org> (raw)
In-Reply-To: <20250512073611.718-2-yohan.joung@sk.com>
On 5/12/25 15:36, yohan.joung wrote:
> when performing buffered writes in a large section,
> overhead is incurred due to the iteration through
> ckpt_valid_blocks within the section.
> when SEGS_PER_SEC is 128, this overhead accounts for 20% within
> the f2fs_write_single_data_page routine.
> as the size of the section increases, the overhead also grows.
> to handle this problem ckpt_valid_blocks is
> added within the section entries.
>
> Test
> insmod null_blk.ko nr_devices=1 completion_nsec=1 submit_queues=8
> hw_queue_depth=64 max_sectors=512 bs=4096 memory_backed=1
> make_f2fs /dev/block/nullb0
> make_f2fs -s 128 /dev/block/nullb0
> fio --bs=512k --size=1536M --rw=write --name=1
> --filename=/mnt/test_dir/seq_write
> --ioengine=io_uring --iodepth=64 --end_fsync=1
>
> before
> SEGS_PER_SEC 1
> 2556MiB/s
> SEGS_PER_SEC 128
> 2145MiB/s
>
> after
> SEGS_PER_SEC 1
> 2556MiB/s
> SEGS_PER_SEC 128
> 2556MiB/s
>
> Signed-off-by: yohan.joung <yohan.joung@sk.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2025-05-12 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 7:36 [PATCH v5 1/2] f2fs: add a method for calculating the remaining blocks in the current segment in LFS mode yohan.joung
2025-05-12 7:36 ` [PATCH v5 2/2] f2fs: add ckpt_valid_blocks to the section entry yohan.joung
2025-05-12 8:32 ` Chao Yu [this message]
2025-05-12 8:33 ` [PATCH v5 1/2] f2fs: add a method for calculating the remaining blocks in the current segment in LFS mode Chao Yu
2025-05-14 15:40 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcb59f9d-a908-4ea4-ba24-af4cfa54145b@kernel.org \
--to=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pilhyun.kim@sk.com \
--cc=yohan.joung@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox