From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: John Garry <john.g.garry@oracle.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] scsi: pm80xx: Avoid -Wflex-array-member-not-at-end warnings
Date: Mon, 8 Sep 2025 20:30:58 +0200 [thread overview]
Message-ID: <bcbbdc13-9b04-45b3-a1fc-20a4bf589850@embeddedor.com> (raw)
In-Reply-To: <47624b76-3b19-4805-b48a-040e943c7f2a@oracle.com>
On 9/5/25 09:05, John Garry wrote:
> On 04/09/2025 15:54, Gustavo A. R. Silva wrote:
>> Remove unused field residual_count in a couple of structures,
>> and with this, fix the following -Wflex-array-member-not-at-end
>> warnings:
>>
>> drivers/scsi/pm8001/pm8001_hwi.h:342:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-
>> not-at-end]
>> drivers/scsi/pm8001/pm80xx_hwi.h:561:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-
>> not-at-end]
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Personally I think that it would be better to comment-out the residual_count member, so that future developers can know about this field and why it is not there.
I agree. I'll send v3.
>
> Anyway,
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
Thanks!
-Gustavo
prev parent reply other threads:[~2025-09-08 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:54 [PATCH v2][next] scsi: pm80xx: Avoid -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-09-05 6:15 ` Jinpu Wang
2025-09-05 7:05 ` John Garry
2025-09-08 18:30 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbbdc13-9b04-45b3-a1fc-20a4bf589850@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=gustavoars@kernel.org \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox