From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org,
nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com,
catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org,
linux-arm-kernel@lists.infradead.org,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 2/5] arm64: Rename unwinder functions
Date: Tue, 30 Nov 2021 11:15:48 -0600 [thread overview]
Message-ID: <bcc2105a-000e-5782-c71f-734dc28c3fbd@linux.microsoft.com> (raw)
In-Reply-To: <YaY+gMPSQMx1M5Pj@FVFF77S0Q05N>
On 11/30/21 9:08 AM, Mark Rutland wrote:
> On Tue, Nov 23, 2021 at 01:37:20PM -0600, madvenka@linux.microsoft.com wrote:
>> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
>>
>> Rename unwinder functions for consistency and better naming.
>>
>> - Rename start_backtrace() to unwind_start().
>> - Rename unwind_frame() to unwind_next().
>> - Rename walk_stackframe() to unwind().
>
> Super trivial, but could we s/unwind_start/unwind_init/ ? That makes it
> slightly clearer that it's not performing an unwind step.
>
> Otherwise, this looks good to me.
>
Will do.
> For the rename:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> It's be nice if we could also clean up 'struct stackframe' into 'struct
> unwind_state', but that can be a follow-up, and this is fine as it is, modulo
> the super trivial comment above.
>
I could do this rename as well in the next version if you want. Might as well
get all the renaming done in one shot.
Thanks,
Madhavan
next prev parent reply other threads:[~2021-11-30 17:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8b861784d85a21a9bf08598938c11aff1b1249b9>
2021-11-23 19:37 ` [PATCH v11 0/5] arm64: Reorganize the unwinder and implement stack trace reliability checks madvenka
2021-11-23 19:37 ` [PATCH v11 1/5] arm64: Call stack_backtrace() only from within walk_stackframe() madvenka
2021-11-25 13:48 ` Mark Brown
2021-11-30 15:05 ` Mark Rutland
2021-11-30 17:13 ` Madhavan T. Venkataraman
2021-11-30 18:29 ` Mark Rutland
2021-11-30 20:29 ` Madhavan T. Venkataraman
2021-12-10 4:13 ` Madhavan T. Venkataraman
2021-11-23 19:37 ` [PATCH v11 2/5] arm64: Rename unwinder functions madvenka
2021-11-24 17:10 ` Mark Brown
2021-11-30 15:08 ` Mark Rutland
2021-11-30 17:15 ` Madhavan T. Venkataraman [this message]
2021-11-23 19:37 ` [PATCH v11 3/5] arm64: Make the unwind loop in unwind() similar to other architectures madvenka
2021-11-25 14:30 ` Mark Brown
2021-11-23 19:37 ` [PATCH v11 4/5] arm64: Introduce stack trace reliability checks in the unwinder madvenka
2021-11-25 14:56 ` Mark Brown
2021-11-25 16:59 ` Madhavan T. Venkataraman
2021-11-26 13:29 ` Mark Brown
2021-11-26 17:23 ` Madhavan T. Venkataraman
2021-11-23 19:37 ` [PATCH v11 5/5] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka
2021-11-25 15:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc2105a-000e-5782-c71f-734dc28c3fbd@linux.microsoft.com \
--to=madvenka@linux.microsoft.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jmorris@namei.org \
--cc=jpoimboe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nobuta.keiya@fujitsu.com \
--cc=sjitindarsingh@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox