Re: [PATCH net-next v6 16/16] net: dsa: vsc73xx: start treating the BR_LEARNING flag

Linus Walleij
2024-03-06T08:36:52Z

On Fri, Mar 1, 2024 at 11:18 PM Pawel Dembicki <paweldembicki@gmail.com> wrote:

> This patch implements .port_pre_bridge_flags() and .port_bridge_flags(),
> which are required for properly treating the BR_LEARNING flag. Also,
> .port_stp_state_set() is tweaked and now disables learning for standalone
> ports.
>
> Disabling learning for standalone ports is required to avoid situations
> where one port sees traffic originating from another, which could cause
> invalid operations.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

This looks right to me:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I looked at all patches that I understand, the VLAN tag stuff needs to
be reviewed by Vladimir who I think has a clear idea of how that should
be done. You can add my Acked-by because I looked at them and they
look right but I can't claim to have made a thorough review on those.

Yours,
Linus Walleij