From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752539AbdJ0Nn4 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 09:43:56 -0400
Received: from mout.web.de ([212.227.17.11]:62662 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752077AbdJ0Nny (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 09:43:54 -0400
Subject: Re: [PATCH] iio/adc/palmas: Use common error handling code in
 palmas_gpadc_calibrate()
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Alison Schofield <amsfield22@gmail.com>,
        "H. Nikolaus Schaller" <hns@goldelico.com>,
        Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <0ae3662d-6a74-622c-0423-e8552ea79bca@users.sourceforge.net>
 <20171026173314.0bd5fd27@archlinux>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <bcd5b722-fe10-8ea0-0f90-662cb414b4c0@users.sourceforge.net>
Date: Fri, 27 Oct 2017 15:43:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171026173314.0bd5fd27@archlinux>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:AkMUm9Acv+dsVGCiXmk1l52YFfS/KzzfaFTdtYWOb8OffuVCKXq
 DcjLsgAu8ppSnTz2sT4WYY9rel2/fn2MTJ1vznf+Af8duJ4itA/c70sUEbpmwgQtqZU+WLV
 Fk26IC2CnstfoZ7mgZBFzyx7XT8VhegwyH6ADVQAQbjmMziOVTbJzNot0lfo7jSFy9a5Hn6
 7nWhaY8wOjr3UT2aXaQZA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:K51MKzCnW1s=:fLVGE6hK+JvdpxzA45I3dK
 SS2SYiWGBxyG9clDTNBafCm4b1IfIf+395GVmRSxs3IM+u9fq0hdgyYz112lXcvlqM9/L9Gnf
 yOIe0YNYFxqZHzwLw4scYnEMdYaOHITPhi++7ca/C6dL4noJ5NEZlhuqXqMCvW7QoJUTjqg0K
 e08zix7mDon0/3kk/ZycvInJta9QgWDnuFAr+IqvzqBKAg6C3P1wTUjfJjTi62KBXPXo+klUr
 pyKrBrURq1zoXisZPUQMHGJyXhpz4olJ3M94WDL270/ixlo2fTxRr4yF9IkzzXGTcrXVZN6a0
 70rir5BA3QtDbDXfVzkoh+YXvs0wxUlUWKCTcV3NgRyAlvz33YZJPn/JastYiTMsKY4Njtdmy
 u9B+TPQMAYn/kddD7Xhy+IeS0SaKy+BLJP85BFVRtD3r8rY+0IozQRbH2Lgj6OV0HvBOqlZcf
 aTibXEY/dcQBTlfvHL/tCxb9BPK6liRmoBiQALeMU8lLgGZFxRazYASZXSFQsH2I4chXyTuwK
 fZWazwFqinWa7lqR5Yrk47VYP4alQ7Sy3AEoXp6eSbj2pUUiMveuMpjD7D1DGB2ZKjaF9D2A+
 i7yAJVy2HsZ7+uCOZMKqHnHlFUAYGavReaTiEh4JB+mlxiICMQrrxzGvfWBGRSj+152Bj+U54
 vvl0JdfviKWKyGo9vddldi8xs7OwLAbDsKBqSV5Ufd9PuMdcKy1RVvUW6qQEhA2/D0eaPcu3t
 tUBI4NFDK7lOvUwb+GnPHRBoLopmjmSCKiM1QTiRW47022+wfLyvPeOhRvudQb9QPDi0GsNoK
 crYHBL9HrcdT7XgOcRtJLOqUyN+Yq5pdBbBeaPRReqmtPIGkKg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -329,6 +325,10 @@ static int palmas_gpadc_calibrate(struct palmas_gpadc *adc, int adc_chan)
>>  
>>  scrub:
>>  	return ret;
>> +
>> +report_failure:
> 
> This makes for complex code flow where it is not needed.

The shown code layout would be required in the suggested software design direction.


> As such I am not going to even think about taking this sort of patch.

It might take more time until similar situations will be reconsidered.


>> +	dev_err(adc->dev, "TRIM read failed: %d\n", ret);
>> +	goto scrub;
>>  }
>>  
>>  static int palmas_gpadc_start_conversion(struct palmas_gpadc *adc, int adc_chan)

Do any other contributors find a bit of code reduction desirable for this
software module?

Regards,
Markus