From: Maulik Shah <mkshah@codeaurora.org>
To: Marc Zyngier <maz@kernel.org>
Cc: swboyd@chromium.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, dianders@chromium.org, rnayak@codeaurora.org,
lsrao@codeaurora.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc
Date: Wed, 17 Mar 2021 15:18:09 +0530 [thread overview]
Message-ID: <bce03166-e65b-198c-8b93-39e0c218aaed@codeaurora.org> (raw)
In-Reply-To: <87k0q6i1g5.wl-maz@kernel.org>
Hi Marc,
On 3/17/2021 2:47 PM, Marc Zyngier wrote:
> On Wed, 17 Mar 2021 05:29:54 +0000,
> Maulik Shah <mkshah@codeaurora.org> wrote:
>> PDC interrupt controller driver do not use second reg. Remove it.
> This is a DT file, not a driver. What the driver does is irrelevant.
>
> The real question is: what does this range do?
>
> Thanks,
>
> M.
This is to set interrupt type in SPI config for which there was a change
[1] but has not gone in for upstream PDC driver.
The second reg is not used in upstream PDC driver, probably when posting
downstream DT changes for sm8350/sm8250 it was carried in device node as is.
As its not mentioned in bindigs as well, dtbs_check reports it as
additional reg when converted to yaml.
[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/1568411962-1022-8-git-send-email-ilina@codeaurora.org/
Thanks,
Maulik
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-03-17 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 5:29 [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc Maulik Shah
2021-03-17 5:29 ` [PATCH 2/3] arm64: dts: qcom: sm8250: " Maulik Shah
2021-03-17 5:29 ` [PATCH 3/3] dt-bindings: interrupt-controller: Convert bindings to yaml for qcom,pdc Maulik Shah
2021-03-17 9:17 ` [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc Marc Zyngier
2021-03-17 9:48 ` Maulik Shah [this message]
2021-03-17 14:02 ` Marc Zyngier
2021-03-17 18:08 ` Bjorn Andersson
2021-03-22 10:26 ` Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bce03166-e65b-198c-8b93-39e0c218aaed@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=maz@kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox