From: Markus Elfring <Markus.Elfring@web.de>
To: make24@iscas.ac.cn, linux-spi@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Brownell <dbrownell@users.sourceforge.net>,
Josh Boyer <jwboyer@linux.vnet.ibm.com>,
Mark Brown <broonie@kernel.org>, Stefan Roese <sr@denx.de>,
"Steven A. Falco" <sfalco@harris.com>
Subject: Re: [PATCH v3] spi: ppc4xx: handle irq_of_parse_and_map() errors
Date: Mon, 22 Jul 2024 17:42:23 +0200 [thread overview]
Message-ID: <bceb4055-e315-4c70-a682-228cb997f86c@web.de> (raw)
In-Reply-To: <20240722141822.1052370-1-make24@iscas.ac.cn>
…
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Will any contributors care more for rules also according to such information?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n398
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/researcher-guidelines.rst?h=v6.10#n5
…
> +++ b/drivers/spi/spi-ppc4xx.c
> @@ -416,6 +416,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op)
> if (hw->irqnum <= 0)
> goto free_host;
>
> + if (hw->irqnum <= 0)
> + goto free_host;
…
Why do you propose anyhow to add duplicate source code here?
Regards,
Markus
next prev parent reply other threads:[~2024-07-22 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 14:18 [PATCH v3] spi: ppc4xx: handle irq_of_parse_and_map() errors Ma Ke
2024-07-22 15:42 ` Markus Elfring [this message]
2024-07-22 17:10 ` Mark Brown
2024-07-22 18:24 ` [v3] " Markus Elfring
2024-07-23 7:45 ` Markus Elfring
2024-08-15 13:32 ` [PATCH v3] " Mark Brown
2024-08-18 22:02 ` lee.lockhey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bceb4055-e315-4c70-a682-228cb997f86c@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=dbrownell@users.sourceforge.net \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=sfalco@harris.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox