From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731EF1EA91 for ; Mon, 27 Jan 2025 18:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738002310; cv=none; b=nMq2nVeC03xzfI7v+t6HbjI5OV34uQMCSAnBImvLQpNssg1rOY1Zuau9NqD4gU+nPlJM3z7MmgZrl+8cFazDNmHEfRj4CobKSnWwcGX0kJ+cgf8PtSoQtrsIn29AcisnOvR+IIDxF8DRMmyxIfqKP1MooO9xlaYMjaS6qiLMIS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738002310; c=relaxed/simple; bh=ZLCYLVFPaphRGJltsPOu1j0v3nQ9Ra/U5rdLPeqfmeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OS08/VGNUMjmrgEJc6UWOQqtLC5+FVucRx3abUzZhUORb4+z1kle+aXM0QAk+lMHz5AB3dqoqSVEEjmBU5yQVMWUa72QmEzJOdGNvdyh+xhxBJlir9aTsmlRRmII7DpAsgbiROupZAIc0AsYd2dzaNb34HbPNiiE9kzREDRtAMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qkJ8mp44; arc=none smtp.client-ip=91.218.175.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qkJ8mp44" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738002301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Imgxozkm6aUWVB9gzKkThS2UchPua13u8YtM2MiEcIQ=; b=qkJ8mp449t69E5hfdt/+sgt2Pz8v/LBsRF/xab3q2SHHaSEVN91uDDJTnX5k6ctYh5um89 vepBVGo0sP6O40g9WKSydJo4q1hvS2DNaTYYRdjkCENWeeYItK9CY5JjoBViwawMCFiFlS rHoTe1SOGziwra6qKvkPG1guNr1xOeg= Date: Tue, 28 Jan 2025 02:24:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net v4 3/3] net: stmmac: Specify hardware capability value when FIFO size isn't specified To: Kunihiko Hayashi , Alexandre Torgue , Jose Abreu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Russell King , Furong Xu <0x1207@gmail.com>, Joao Pinto , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250127013820.2941044-1-hayashi.kunihiko@socionext.com> <20250127013820.2941044-4-hayashi.kunihiko@socionext.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanteng Si In-Reply-To: <20250127013820.2941044-4-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 1/27/25 09:38, Kunihiko Hayashi 写道: > When Tx/Rx FIFO size is not specified in advance, the driver checks if > the value is zero and sets the hardware capability value in functions > where that value is used. > > Consolidate the check and settings into function stmmac_hw_init() and > remove redundant other statements. > > If FIFO size is zero and the hardware capability also doesn't have upper > limit values, return with an error message. > > Signed-off-by: Kunihiko Hayashi Reviewed-by: Yanteng Si Thanks, Yanteng