From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8BFC77B73 for ; Tue, 30 May 2023 11:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231234AbjE3L5h (ORCPT ); Tue, 30 May 2023 07:57:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230302AbjE3L5c (ORCPT ); Tue, 30 May 2023 07:57:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC9DFE4F; Tue, 30 May 2023 04:56:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A98E262E9B; Tue, 30 May 2023 11:56:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EA45C433AC; Tue, 30 May 2023 11:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685447778; bh=KeOWYbGzBY6vsVhyFwQJbzeNpJ1yJW9UJp+AlHyUM4Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KxfGhgSzSTG4M0ESseMtRydcsomhRiE3JIbU1OGrM17QfJcmsWCtomRLTgl/Ytj1b jFxplFqiRHFwszV2wH8grmmKzdccd6qUeBZ8vKPG4Glgp3SnwKYxnlfOLrVO/ce8eT 9zXeNMswtHe4OV8TyYq7LGGhSuRUaIE7KAJogJEZX16H2FZptFLcNC/EaYEDjNgSV1 cDIH1EDaYygPaP6517e6MfVZvoz4hKSB85xwwIJHSGmKt/LmDbpxK7uL+fAjpmgQ+w 3PWLR98vtGFU+boagrlLLZbUxOidH7gnjHxsz4j0IEKlO3LnQ61t7gYM8exypWLP3C 34oFGGlh/i+cQ== Message-ID: Date: Tue, 30 May 2023 13:56:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [v2 2/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip Content-Language: en-US To: Doug Anderson , Cong Yang Cc: benjamin.tissoires@redhat.com, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, hsinyi@google.com, jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org References: <20230520050649.2494497-1-yangcong5@huaqin.corp-partner.google.com> <20230520050649.2494497-3-yangcong5@huaqin.corp-partner.google.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/05/2023 17:33, Doug Anderson wrote: > Hi, > > On Fri, May 19, 2023 at 10:07 PM Cong Yang > wrote: >> >> Add an ilitek touch screen chip ili9882t. >> >> Signed-off-by: Cong Yang >> --- >> .../devicetree/bindings/input/elan,ekth6915.yaml | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) > > I'm curious about the DT maintainers opinion here. Should this be a > new bindings file, or should it be together in the elan file. If > nothing else, I think the secondary voltage rail name is wrong. I took > a quick peek at a datasheet I found and I don't even see a 3.3V rail > going to the ili9882t. That makes it weird to reuse "vcc33-supply" for > a second supply... It's easier if they are CCed... Best regards, Krzysztof