From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BAA924E4BD; Thu, 6 Nov 2025 15:17:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762442270; cv=none; b=idVzcSdarxvOIDWuuNbLQd/m9Pca92C17fDSTJuBrFtQAvrTFLjMZ9/OsY2U6lv8DMpL1FNecKT4lWUXgDOETC8OZgN+pL/v6yraPQJvRIBRTLjaNjVgu5fCRNxDpzlu6rgUyKVBuN5cITFjbUTTWHi7P9+LJY/IoEHnuweaEIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762442270; c=relaxed/simple; bh=DRgu+1zEiLJzFvpqNcYywnec1hhXYCa75y4/TrlRBwg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=tXY2dtWvDIfkKR7p+FyWXgbcdeCZQSPRXcPaboBfSwEqS/iNfhpc6M38P6dG7rvlv23lYCSfoh3XoTTXKsVa+zvPULzQ1ZCdIg69ieeUe+0Yehr68LhMLtYmnvB9EnXakDZLTLlgcg7LsREPOXln6c3Aqg0Qe2O+8Z+8snxYC7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=H3PJOxvt; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="H3PJOxvt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1762442266; bh=DRgu+1zEiLJzFvpqNcYywnec1hhXYCa75y4/TrlRBwg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=H3PJOxvtqbQ72kA29/dtPRySRy3X/JZY1JnX8vB8mMpkAnGTDMeazey1oWJ2Ho9bt zeyRgpkd6g8h6igHZu13qSn79r4sGm7JHTfoDCk8iAX1CHOFL+AxPlO4inD6jJ1QqB uPQrJdaTa1qv33cFL6/UrVxby54yqTFa+ngnn6rQ5plXOROKyynfxGemVj56YAIDCt D/evrmMFyB4XrDTUjJMYmLQiugeCmw2UdOWrpJPgLxqjgs5wRcuGmlmi52GRaxxVHg 8LUUNLXrhQl8bSoRw4FfLkKQW4xHjNzNSlBQJ/s523TL00QFWSRe4L5hYjAft+T3LG eXeZ4etQ4nneA== Received: from [IPv6:2606:6d00:11:ef24::c41] (unknown [IPv6:2606:6d00:11:ef24::c41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id CFAF817E090D; Thu, 6 Nov 2025 16:17:43 +0100 (CET) Message-ID: Subject: Re: [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2 From: Nicolas Dufresne To: Kyrie Wu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Nathan Hebert , Arnd Bergmann , Irui Wang , George Sun , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Yilong Zhou Cc: Neil Armstrong , Andrzej Pietrasiewicz Date: Thu, 06 Nov 2025 10:17:42 -0500 In-Reply-To: <20251106061323.2193-6-kyrie.wu@mediatek.com> References: <20251106061323.2193-1-kyrie.wu@mediatek.com> <20251106061323.2193-6-kyrie.wu@mediatek.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-p4Bu9/Ayloxs70Y/YXH1" User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-p4Bu9/Ayloxs70Y/YXH1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Le jeudi 06 novembre 2025 =C3=A0 14:13 +0800, Kyrie Wu a =C3=A9crit=C2=A0: > The dram addr of vp9 decoder tile number, which use dram mode > to set tile information, may reach to 36bits for 4096x2176. > It needs to get the highest 4bit of tile buffer address to > set tile buffer address. An after thought, I don't see any call to vb2_dma_contig_set_max_seg_size()= or dma_set_coherent_mask() with DMA_BIT_MASK(32)/DMA_BIT_MASK(36) in this driv= er. How do you control this ? Nicolas >=20 > Fixes: 5d418351ca8f1 ("media: mediatek: vcodec: support stateless VP9 > decoding") >=20 > Signed-off-by: Kyrie Wu > Reviewed-by: AngeloGioacchino Del Regno > > --- > =C2=A0.../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 5 ++++- > =C2=A01 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git > a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if= .c > b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if= .c > index d966914db4b9..91c563c049bd 100644 > --- > a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if= .c > +++ > b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if= .c > @@ -1156,7 +1156,10 @@ static int vdec_vp9_slice_setup_tile_buffer(struct > vdec_vp9_slice_instance *inst > =C2=A0 tiles->size[i][j] =3D size; > =C2=A0 if (tiles->mi_rows[i]) { > =C2=A0 *tb++ =3D (size << 3) + ((offset << 3) & 0x7f); > - *tb++ =3D pa & ~0xf; > + *tb =3D pa & ~0xf; > + if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT)) > + *tb |=3D (pa >> 32) & 0xf; > + tb++; > =C2=A0 *tb++ =3D (pa << 3) & 0x7f; > =C2=A0 mi_row =3D (tiles->mi_rows[i] - 1) & 0x1ff; > =C2=A0 mi_col =3D (tiles->mi_cols[j] - 1) & 0x3f; --=-p4Bu9/Ayloxs70Y/YXH1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaQy8FgAKCRDZQZRRKWBy 9NPSAP4g8gTapYL8m2LxcUUuZCeWMhCOGTCX8BR5UqAbTL8qfwD/WKrYbiY+6bxl DWa6+3ECPDXoTJi+A2WmiP1MGLhfOQc= =PEsx -----END PGP SIGNATURE----- --=-p4Bu9/Ayloxs70Y/YXH1--