From: Paolo Abeni <pabeni@redhat.com>
To: Wang Liang <wangliang74@huawei.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, shuah@kernel.org
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, yuehaibing@huawei.com,
zhangchangzhong@huawei.com
Subject: Re: [PATCH net-next] selftests: net: check jq command is supported
Date: Fri, 10 Oct 2025 16:56:29 +0200 [thread overview]
Message-ID: <bd3149e8-e213-48b0-8f8a-0888d1837b84@redhat.com> (raw)
In-Reply-To: <20251010033043.140501-1-wangliang74@huawei.com>
On 10/10/25 5:30 AM, Wang Liang wrote:
> The jq command is used in vlan_bridge_binding.sh, if it is not supported,
> the test will spam the following log.
>
> # ./vlan_bridge_binding.sh: line 51: jq: command not found
> # ./vlan_bridge_binding.sh: line 51: jq: command not found
> # ./vlan_bridge_binding.sh: line 51: jq: command not found
> # ./vlan_bridge_binding.sh: line 51: jq: command not found
> # ./vlan_bridge_binding.sh: line 51: jq: command not found
> # TEST: Test bridge_binding on->off when lower down [FAIL]
> # Got operstate of , expected 0
>
> The rtnetlink.sh has the same problem. It makes sense to check if jq is
> installed before running these tests. After this patch, the
> vlan_bridge_binding.sh skipped if jq is not supported:
>
> # timeout set to 3600
> # selftests: net: vlan_bridge_binding.sh
> # TEST: jq not installed [SKIP]
>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
This looks more a fix than net-next material (and net-next is currently
closed for the merge window).
Please re-post for net including suitable fixes tag(s). You can retain
Hangbin's ack.
Thanks,
Paolo
next prev parent reply other threads:[~2025-10-10 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 3:30 [PATCH net-next] selftests: net: check jq command is supported Wang Liang
2025-10-10 10:02 ` Hangbin Liu
2025-10-10 14:56 ` Paolo Abeni [this message]
2025-10-11 3:26 ` Wang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd3149e8-e213-48b0-8f8a-0888d1837b84@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox