From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan Brattlof <bb@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial infrastructure
Date: Thu, 8 May 2025 08:56:58 +0200 [thread overview]
Message-ID: <bd33bfa6-9d31-457d-a1bf-66151e92900b@kernel.org> (raw)
In-Reply-To: <20250508-illegal-caracara-from-hyperborea-b77eda@kuoka>
On 08/05/2025 08:52, Krzysztof Kozlowski wrote:
> On Wed, May 07, 2025 at 10:09:20PM GMT, Bryan Brattlof wrote:
>> +
>> + uart6: serial@2860000 {
>> + compatible = "ti,am64-uart", "ti,am654-uart";
>> + reg = <0x00 0x02860000 0x00 0x100>;
>> + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
>> + power-domains = <&scmi_pds 82>;
>> + clocks = <&scmi_clk 322>;
>> + clock-names = "fclk";
>> + status = "disabled";
>> + };
>> +
>> + conf: syscon@9000000 {
>> + compatible = "syscon", "simple-mfd";
>
> Not much improved here. You cannot have such compatibles alone and the
> bindings test this.
>
> Are you sure you tested this?
I now tested it and I am 100% sure you did not.
Use tools and computers instead of humans for finding trivial issues.
This is not really acceptable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-08 6:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 3:09 [PATCH v5 0/3] arm64: dts: ti: introduce basic support for the AM62L Bryan Brattlof
2025-05-08 3:09 ` [PATCH v5 1/3] dt-bindings: arm: ti: Add binding for AM62L SoCs Bryan Brattlof
2025-05-08 4:08 ` Rob Herring (Arm)
2025-05-08 6:51 ` Krzysztof Kozlowski
2025-05-08 13:14 ` Bryan Brattlof
2025-05-08 15:46 ` Krzysztof Kozlowski
2025-05-08 3:09 ` [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial infrastructure Bryan Brattlof
2025-05-08 6:52 ` Krzysztof Kozlowski
2025-05-08 6:56 ` Krzysztof Kozlowski [this message]
2025-05-08 12:33 ` Nishanth Menon
2025-05-08 13:12 ` Bryan Brattlof
2025-05-16 10:23 ` Sascha Hauer
2025-05-16 12:23 ` Bryan Brattlof
2025-05-27 12:06 ` Sascha Hauer
2025-06-03 13:38 ` Sascha Hauer
2025-06-03 13:47 ` Bryan Brattlof
2025-05-08 3:09 ` [PATCH v5 3/3] arm64: dts: ti: k3-am62l: add initial reference board file Bryan Brattlof
2025-05-09 14:16 ` [PATCH v5 0/3] arm64: dts: ti: introduce basic support for the AM62L Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd33bfa6-9d31-457d-a1bf-66151e92900b@kernel.org \
--to=krzk@kernel.org \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox