From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754125AbeEaIXk (ORCPT ); Thu, 31 May 2018 04:23:40 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37879 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbeEaIXg (ORCPT ); Thu, 31 May 2018 04:23:36 -0400 X-Google-Smtp-Source: ADUXVKI7R36M85sQmn49VDGCS9DGqzsuzqHV1wsLqnGSzJBSK3JDQX7UXJZljvZt3vDOvRRgEsoBZg== Subject: Re: [PATCH v2 15/29] venus: helpers: rename a helper function and use buffer mode from caps To: Tomasz Figa Cc: Mauro Carvalho Chehab , Hans Verkuil , Linux Media Mailing List , Linux Kernel Mailing List , linux-arm-msm , vgarodia@codeaurora.org References: <20180515075859.17217-1-stanimir.varbanov@linaro.org> <20180515075859.17217-16-stanimir.varbanov@linaro.org> From: Stanimir Varbanov Message-ID: Date: Thu, 31 May 2018 11:23:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz, Thanks for the review! On 05/31/2018 10:59 AM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:06 PM Stanimir Varbanov > wrote: >> >> Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and >> use buffer mode from enumerated per codec capabilities. >> >> Signed-off-by: Stanimir Varbanov >> --- >> drivers/media/platform/qcom/venus/helpers.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c >> index 2b21f6ed7502..1eda19adbf28 100644 >> --- a/drivers/media/platform/qcom/venus/helpers.c >> +++ b/drivers/media/platform/qcom/venus/helpers.c >> @@ -354,18 +354,19 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf) >> return 0; >> } >> >> -static inline int is_reg_unreg_needed(struct venus_inst *inst) >> +static inline int is_dynamic_bufmode(struct venus_inst *inst) > > nit: Could be made bool. And drop inline I guess? :) -- regards, Stan