From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Paolo Valente <paolo.valente@linaro.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] bfq probe failed on 4.19-rc3
Date: Tue, 11 Sep 2018 10:49:05 -0600 [thread overview]
Message-ID: <bd71494f-4595-7586-4c46-000f2b2029aa@kernel.dk> (raw)
In-Reply-To: <x49a7ooj7zp.fsf@segfault.boston.devel.redhat.com>
On 9/11/18 10:48 AM, Jeff Moyer wrote:
> Jens Axboe <axboe@kernel.dk> writes:
>
>> On 9/11/18 10:03 AM, Takashi Iwai wrote:
>>> Hi,
>>>
>>> I noticed that bfq doesn't appear in the I/O scheduler list on
>>> 4.19-rc3. It seems that blkcg_policy_register() at the beginning of
>>> bfq_init() returns -ENOSPC, hence the probe aborts silently.
>>>
>>> Is this already addressed?
>>
>> Haven't heard about this one before. What kernel did you last use that
>> worked?
>
> I'm guessing you just need to update the maximum number of policies:
>
> /*
> * Maximum number of blkcg policies allowed to be registered concurrently.
> * Defined here to simplify include dependency.
> */
> #define BLKCG_MAX_POLS 3
That is my guess too, hence the suggestion to try and disable the
iolatency policy. Just tried here without, and it works, rebooting
with to verify that we're running out of policy slots.
--
Jens Axboe
next prev parent reply other threads:[~2018-09-11 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 16:03 [REGRESSION] bfq probe failed on 4.19-rc3 Takashi Iwai
2018-09-11 16:09 ` Jens Axboe
2018-09-11 16:11 ` Takashi Iwai
2018-09-11 16:16 ` Takashi Iwai
2018-09-11 16:20 ` Jens Axboe
2018-09-11 16:48 ` Jeff Moyer
2018-09-11 16:49 ` Jens Axboe [this message]
2018-09-11 16:51 ` Jeff Moyer
2018-09-11 16:54 ` Jens Axboe
2018-09-11 16:57 ` Jeff Moyer
2018-09-11 16:59 ` Jens Axboe
2018-09-12 8:58 ` Takashi Iwai
2018-09-12 14:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd71494f-4595-7586-4c46-000f2b2029aa@kernel.dk \
--to=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox