From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79E0A3B2AA for ; Tue, 5 May 2026 00:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777939877; cv=none; b=RqbTol4B7Ry11jINsAOpV8cC8sp388mvbuh5ZNp99QfAXisk2gbgFMj3v+sXutyue9XhUEb16NG4H6ckGWBuMWYAKSaFgjILpGc7Kth2v0vrjyxevJzX/S7iDhYH4l8zAGOejwGCDzE9nL1qahX/8/4cRhCfAIF73aKt+WELSfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777939877; c=relaxed/simple; bh=vtW70XD7sgH1la6jbceNOWaOTwUM5D0j2nHs+xlyJC0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tw2zLu3OopZQ6r0OBlmLEkmCSPH++GwW5CGSxvP30sgXQhpwKvC5z4rHEl6tMGZ1NlYSFIMBLwfsC90/iIZURvQiXCBOdlHGo2KX3DlTn2HoSehwLBHEtFOwemuffAWVSrjM3MGEfOrhH/82MuM8WyM88EK/AVoWtXyTJrXZRqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nRuKzQU2; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nRuKzQU2" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2ee1054627bso3189895eec.1 for ; Mon, 04 May 2026 17:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777939876; x=1778544676; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qd/krIT/1cSoLMMya0JMIdHmRHAFdBg2W/mBeQ6dU54=; b=nRuKzQU206xVMp9eAtUnNmf67sbnZD3+J4gjRs8ChwWORJVg/na9VF5gyQAWNFsbgL PziIm0yt0j5CL6A51C7Ew83GfEgCkXav6LLZoTOcplx7Gg0RK73z2U/Eb2cNP0HxjfQT 9/OslOLk2syPVQVl0yyMrYXndfLmjcjYduXDlHcOSWtVlCni+g4gtTwrcn0IHTJg/udg 5u16gb4dNSPwVpM/xCWBWUR19QB93nGiE8/5fMmd/x1Y06EL7Gmzb1q+pQ0pkpfELF7n 7rm1fZYrXZPfS6siwyFXedgx3nTun+dvx4eb5xzSNDM3exEmibvKrW3JJziaSTWSmlzZ 4PxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777939876; x=1778544676; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qd/krIT/1cSoLMMya0JMIdHmRHAFdBg2W/mBeQ6dU54=; b=MYzQNFQ+ipBOIoOW79td/rrVDsFDUjxrdmRJ4FXR2EViy7YhBJn9zjoweg07oE6cIS XtRRhfSsUK1CgHpF4CI0mKm0NOE2N6Ov+a2YKUXTq2UfvVqGNxGnxo/71rwLpiEfzeMf wrkyDxT2NKPsfgt8OAtb2O8OyMqJpcCTBZahHSxLu8NIOnKIKj1zKsyDvjciR3ZxmBA1 i7qs298XYKwPacMsrjkRwc2rQ9Fy38khTOX+z2EXcDoOX5tCg8MQlGK0jNIvLdb3j9sW PUF+BXADb/D/QEH6ZM3yQQoaUGxBvYTTyd/oiuBMzVB1NwgPJAmpX/kQkeVuxh7F4Dkx OoSQ== X-Forwarded-Encrypted: i=1; AFNElJ9jlR8hNC4cMz1LyVLSm29NobgS4Grt70r9MwCoRSEf25ktBZZyrM67In9Pnpacw8p+pXG4+OIyJjWYJfM=@vger.kernel.org X-Gm-Message-State: AOJu0YwAOE2gD5WNIAEbob7cBESqKOG0P5/YCA/fkN2AANEpXv1wvJjC agKmTj9nh4fUK7Ha+h3CH/ce14Xqyt6CtM/hfzv97LZ+hmTZOZ2eRsQ= X-Gm-Gg: AeBDietCTDArkW7J9/tkwmYoOjAjRrJEVnOiHZPeK4tsKnPvI/TbEV8o2LHzD+UvXfZ dSgc9nBZ568s1EzT+z8s/rnXRnQb83wqw5sli4IHTfpXnA/mUlP3k8YmPHTrhXEu2DzcseeDt5G TVwy4LiwVC72nZ8v412wn9ePTm4yxhhTfRg+9zMwaihVl2j+1m7K92DpMrptJLPKagce599UVEi VVg1bSCGlDHfdDwmzQsdi+Og8LmaEfb9zPs8F7cZXSjHZHCLcKPIQG3VuGZYZF658/kLIwLhhk9 ZuTeT0hKofm0PHcDAB7H4lY5yKBX2FbpbTi+HBcz/TQtHh31WZE8+cD6eOswrZLbMm/X8w1Eijy SkpDj7zCdgQrZSSZ9xCyZspxgydpcTUrfPoIGY8fTTX2Cp6AeEwJerghxQO9DlvMkJHHTvxpqih 4ETRGoX+1Qkw76umiromLaaUq9xSW0gXNP4ZuJY0tPXMJZ0++7DfNgLmzD4LI0wOE0n5Kti0WpN NkFdiiX X-Received: by 2002:a05:7300:ca8:b0:2f3:b7b2:cbd3 with SMTP id 5a478bee46e88-2f3ce9f1febmr945308eec.5.1777939875407; Mon, 04 May 2026 17:11:15 -0700 (PDT) Received: from [10.100.6.77] (LAMBDA-INC.bar2.SanFrancisco1.Level3.net. [4.7.9.202]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee38d79eb9sm24529936eec.8.2026.05.04.17.11.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 17:11:15 -0700 (PDT) Message-ID: Date: Mon, 4 May 2026 17:11:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RDMA/srpt: fix integer overflow in immediate data length check To: Bart Van Assche , jgg@ziepe.ca Cc: leon@kernel.org, dledford@redhat.com, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, carlos.bilbao@kernel.org References: <20260504080036.3482415-1-sarajvenkatesh@gmail.com> Content-Language: en-US From: Sara Venkatesh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Bart, Yes, tested with blktests srp suite against this patch on 7.1.0-rc2: srp/001 ... [passed] srp/002 ... [passed] srp/005 ... [passed] srp/006 ... [passed] srp/007 ... [passed] srp/008 ... [passed] srp/009 ... [passed] srp/010 ... [passed] srp/011 ... [passed] srp/012 ... [passed] srp/013 ... [passed] srp/014 ... [passed] srp/016 ... [passed] srp/003 and srp/004 are [not run] (legacy device mapper support missing). Thanks, Sara On 5/4/26 01:17, Bart Van Assche wrote: > On 5/4/26 10:00 AM, Sara Venkatesh wrote: >> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c >> b/drivers/infiniband/ulp/srpt/ib_srpt.c >> index 9aec5d80117f..f66cfd70c263 100644 >> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c >> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c >> @@ -1129,9 +1129,10 @@ static int srpt_get_desc_tbl(struct >> srpt_recv_ioctx *recv_ioctx, >>           struct srp_imm_buf *imm_buf = srpt_get_desc_buf(srp_cmd); >>           void *data = (void *)srp_cmd + imm_data_offset; >>           uint32_t len = be32_to_cpu(imm_buf->len); >> -        uint32_t req_size = imm_data_offset + len; >> +        uint32_t req_size; >>   -        if (req_size > srp_max_req_size) { >> +        if (check_add_overflow((uint32_t)imm_data_offset, len, >> &req_size) || >> +            req_size > srp_max_req_size) { >>               pr_err("Immediate data (length %d + %d) exceeds request >> size %d\n", >>                      imm_data_offset, len, srp_max_req_size); >>               return -EINVAL; > > Do the srp tests from https://github.com/linux-blktests/blktests/ still > pass with this patch applied? > > Thanks, > > Bart.