From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB4633ADA0 for ; Wed, 25 Mar 2026 18:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464825; cv=none; b=kSGDf67Xv8kRFpdaXNQvTQLdCxLkb7lLZxYzrKId2yIr5wDBddc2JGuOnrdWUsRRutDmfGpn7xxoezW0x0MPxsUnOQ3RD4yAFMOwAw+V3XJbcVw+o6VW/ryby4EnsjWNOcWDmRq/2ljpmjpC22E2aO++4OigNPYEmW32VWDlt6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464825; c=relaxed/simple; bh=DWPVkjA08pWs9L84PlqyEpGdDMx3hTuqvHKXD6npiTo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xq9RFEOrL12uxDhpt0O09CjiJCfZ++L6X2HvkiTGziA3g38Tci3TRlgUlbfy/h6mb/zKVAatN4lJMoQ5MJJLlbdudkpcCu1ad315k/ZfNvwrhCxzsOPtcvA0C2sF13IDgvrQ2w4oLpVzTN76P7Lcb4AxTaf5aLsDqnICpVGA2DA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=roafwc03; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="roafwc03" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F0B5C4CEF7; Wed, 25 Mar 2026 18:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774464825; bh=DWPVkjA08pWs9L84PlqyEpGdDMx3hTuqvHKXD6npiTo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=roafwc03MEWl11BuAq+xLv1oJM9C9F93dJpwE3bC8keBvTTjO1PSRaXXKY3j1eVEk tixc2n0tiZ0XVc6fSSR6ltE/SZI6p2GnRKO+2A79CdD4IpA/St+Qe9Y1ugvj3F5omH G+U60lPQPaiCPlDa+HiZuM3chuTulPVsoJownl2aMAiHeBCUvxIF17yJjdfbsV6L2a T1HiQApgoFoG4sqTtRyfkGd/hcoGaeinyDgPikEGkkqiWTYkwtJ0GPbsNLZRrSDtLs DzL6BbhZpy8Bjr0i1lsG3iTkdu0+cFunsruBxv9+id4BqSFIC6CHdmoIHwf0dDpBiX 6GRarXRN70eoA== Date: Wed, 25 Mar 2026 18:53:40 +0000 From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: "David Hildenbrand (Arm)" , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number Message-ID: References: <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> <20260325091735.bf440358cf83c5d0369e0674@linux-foundation.org> <06c83e1b-d7ee-48d5-a5c4-faad39db2f53@lucifer.local> <20260325113650.fc6997e07a0a4ad0e46278d5@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325113650.fc6997e07a0a4ad0e46278d5@linux-foundation.org> On Wed, Mar 25, 2026 at 11:36:50AM -0700, Andrew Morton wrote: > On Wed, 25 Mar 2026 16:26:12 +0000 "Lorenzo Stoakes (Oracle)" wrote: > > > > hm OK, so what to do. We're OK with teeny -fixes but anything more > > > substantial we ask for a full resend and I do the heres-what-changed > > > reply? > > > > > > > Yeah that works for me. > > > > > I presently don't fold the -fixes until the very last moment. Could do > > > that much earlier if it helps anything? Possibly useful to people who > > > are looking at the series in the mm.git tree. > > > > It'd generally be easier imo to have those changes folded, but with something > > added to the commit message to indicate this so I can know whether or not that > > was folded in. > > I always add a [footer] when folding -fixes, eg: > > [sj@kernel.org: verify found biggest system ram] > Link: https://lkml.kernel.org/r/20260317144725.88524-1-sj@kernel.org > Link: https://lkml.kernel.org/r/20260311052927.93921-3-sj@kernel.org > Signed-off-by: SeongJae Park > Cc: Yang yingliang > > So one can simply chase the link. > > > An unfortunate exception is when the -fix is from myself - I don't take > the patch from a mailing list so I have no Link: to include, eg > > [akpm@linux-foundation.org: fix spello, add comment] > Link: https://lkml.kernel.org/r/20260220151500.13585-1-rioo.tsukatsukii@gmail.com > Signed-off-by: Rio > Cc: Joel Granados > Cc: Petr Mladek > Cc: Wang Jinchao > Signed-off-by: Andrew Morton > > But these things are usually quite minor and the precipitating > discussion can be found by reading the main Link:. > > > Maybe just directly squash the commits? > > Not understanding this proposal? I mean instead of having a separate commit for the fix, put that fix into the patch before it and denote it with a footer as you put above. I guess that translates to what you do when you rebase and fold the fixes into commits as you do now anyway. I don't see any reason not to do that right away, as really it's good to see the combined change in one go for all practical purposes (if I resend, I'll be combining work, if I can grab it from the tree and avoid a git rebase -i all the better). Thanks, Lorenzo