From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95E0C28D13 for ; Mon, 22 Aug 2022 21:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238311AbiHVVof (ORCPT ); Mon, 22 Aug 2022 17:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238283AbiHVVoW (ORCPT ); Mon, 22 Aug 2022 17:44:22 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 853B34DB5E for ; Mon, 22 Aug 2022 14:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661204661; x=1692740661; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=I/APJLw3N5Gycwk6ZwEtRyX+OrahnhXskpsQXycDjI8=; b=NQspfIUPDAx53hXSA/vaEy9jiKgXQ+Wyy1Dz0fLgyHGT8lgI1J8fh3HB qKl0HXYCnebP5NoCvDtESAXE06tCE/Q3iLvzaQzcK9XkY+7J0+J6dFtG0 0/Fz/FnzBw5W4cljFvPCDXopXpn0ezSVB58W2fpsyJgoFIjhnAppqus5T BLBCzfBK/K1NqzIWCeHkm7r/Jx0zwA15iEfJEOyZsnXCD9S/dDFZhN/fI YLAduMbP+VlRBaAvhHZ1Jdx1nIa/+ERF5IIQWejlLm4aQ17SFDNWXxt3D OcYV7IiksTviahduSWCkzUjG0fpaNk10USSxwRJ2iKyUd7fwWEgLvBCMj Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="273278557" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="273278557" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 14:44:21 -0700 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="751441053" Received: from jcsarker-mobl.amr.corp.intel.com (HELO [10.212.204.203]) ([10.212.204.203]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 14:44:20 -0700 Message-ID: Date: Mon, 22 Aug 2022 14:44:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface driver Content-Language: en-US To: Borislav Petkov Cc: Kuppuswamy Sathyanarayanan , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org References: <20220728034420.648314-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220728034420.648314-2-sathyanarayanan.kuppuswamy@linux.intel.com> <20abfa00-b70c-f151-9ee4-5668f09f4ace@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/22/22 14:36, Borislav Petkov wrote: > Which makes my initial suggestion of calling this whole guest > functionality a "tdx" driver not such a bad idea... Depends on > whether there will be a split at all or it'll continue gaining more > functionality. Yep, let's get the crystal ball out. TDX folks: What other ioctl()s are in the pipeline for the guest side? What ioctl()s are in the pipeline for the host side? Are they all part of /dev/kvm, or are there any TDX-specific "drivers" for the host? We want to avoid both: 1. A driver called /dev/tdx (or "tdx-guest) which is only and will only ever do TDX guest attestation. 2. A driver called /dev/tdx-guest-attest which shares a ton of functionality with some future TDX guest feature like /dev/tdx-guest-snazzy-feature-foo. Then, a new driver every time a new snazzy TDX feature shows up.