Re: [PATCH 0/2] iio: dac: adi-axi-dac: fix for wrong bus read

Nuno Sá
2025-04-09T07:17:13Z

On Tue, 2025-04-08 at 22:48 +0200, Angelo Dureghello wrote:
> This patchset is intended to fix a random wrong chip ID read, or a
> scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The
> bus "read" operation must always check for busy flag before reading.
>
> First patch reorganizes a bit the busy-wait polling code, second patch
> fixes the wrong bus read occurence.
>
> NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be
> applied after the linked "ramp generator" patch.
>
> Link:
> https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---

Hi Angelo, patches look good but typically fixes should come first. The reason is
that we only want to backport fixes to stable branches and like this we depend on the
first patch. So first use the plain regmap_read_poll_timeout() before accessing the
bus and then add the helper...

- Nuno Sá