From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4DC8229B18 for ; Fri, 16 Jan 2026 15:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768576330; cv=none; b=EaB/nHGhxoRvArPQR2J2cPXjaBwEsyZJmMQhP54/K4vXk1WKBqCraA1soNoScna9Fv+txcnlCPONnYy/dPc/GXKrAHTYanifCO6WYlv8UBSCpYyY/2rYM0hUbsLcm8cN9WVCYzbsesMcCKoPl+/zNL/VIDWGW9n28dvvoAQD2Jk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768576330; c=relaxed/simple; bh=ke4jGI/pMpYJhUdZT278oUx9DIiJ/Ksah+i3cNMi1Us=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I0FSd/xbdIfhx/tabIM9HbnmCm8WdvJL69A5p5BqTwBTxVFLnhA91DYEADnVm/QjZLKpcHjcz3SaxL77ctCHlIXV5cJaj591g/t0apK6+8ziiprGNp7c4yZBQfo1WZU4EDhi53RWGktcmwV0GlUUIJktY5IlcIqJQ05KOdQT/Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QfNLbdQG; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QfNLbdQG" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a07fac8aa1so15107295ad.1 for ; Fri, 16 Jan 2026 07:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768576329; x=1769181129; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tQu3pTdsFxlcxxivNtgR//4Npg5GzUX/0HfS0u02h/Q=; b=QfNLbdQGOsINF5ZiIgmyg7rYORMtTTT29kguZRPQUoeBNhCID++cb43AoRhvDmVZoy AfPjvPWpRNRuhP9yZ09int/EiobIRJLV42rLY9vtNK8zNo93kEHksvjtj5hn95w+N79m PXcuq2judlWWvFjH0h99IRao54k7Fvn3+oGmn8Sh4Xc6CoU7gnVFB3gE6ivzS8BI+QP+ lnBZIe4dC+hFAS6IIGZLVUW+N1Ax+abXCCMkaW5+crQ4Tg1EwUytVlCKPYtlpkAc5ZkF uhfSzNXHI0bZQjElTohntDCd1J8IogYBN6M3sLSfwVPU+B70eLNDaevzOEpyjMOntlrQ q30g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768576329; x=1769181129; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tQu3pTdsFxlcxxivNtgR//4Npg5GzUX/0HfS0u02h/Q=; b=ubWVL8W732XeAtPKKBtkgcz6Jqwy1GZyBzXZehvOlo9DpTlZ9JzBkXS+XKl6ASnw0z 6H84CYBYDs+7kwu6+n5DfFOQd0fjMe1jpusaXsERqDzyRajdKr6Gu0Vt74CRkBLOEufu vCQBzrtRXGN8u3SSvQfbPjE8G8hZVqJh+KUXyMBvkRcpit4LO+JsMAAZMsO9JpRSJwZL eVhYDSo5eWKuu0Cdxgq7BOd06Cl/4F6MQFCbuVzYkC7UCgrJoelNI7O7OGgeJ1+L/5OW eejK2RhVwSxgOcDvtdLPt4lpQOWlcTpZUaALn3IbTgbaD4bpHBM35tU0j84a51FEwp9M m1+g== X-Forwarded-Encrypted: i=1; AJvYcCVUVUr7Msj9mLEwnUyqWtPWOwZrWdTmI0K5JZ/JattPyBN/FWc+xw2RZisrhOsO177oJRRe6bNdsVftTqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyHs9qu2c8VcFbEd/c7oaHbuYR3JJFjNc2MF8p/FOMSk8PwWKiZ tQREv9A3JC7LiM3Alsb3pGunTJZlAtqtE6VI3TO/h2ffwPBan2bcFYoP X-Gm-Gg: AY/fxX6kxR7EkJW8DBVTYHO17IXna06gYQtP94nmmQSZhbMzjNGjUbyBumO1FXTLGVR kcvJjkHfYwWUN3a7aI8CHSlekOeks2O23muUHWqlRQklnNag4bK2gIUHk4TXjxngaUaimCPXAGJ UyfHMOcb3jm0dOq60YT/twMjjOqYEBMLxvd7amGOsw5XLEuyd7SqLkM/aLZyXzu6qk16B7Oa68R 6854CNfChh3ynMQbUrS7Mb/FGhz7gsXnd9V/G2fCXspoHdI2TRSc+5zT6J/qKnNfl7w4i1dvJSr XuDRa4I93VF2AHlVfdezsHb8yGbRfvDhBFHjEJfkT3XTFLcuQ+YQsgkthX4PB0T6aRHKFjZwRsf t2BgcCC24khJYJoD+UazLNZ6DewDDyykKS1ECTBaF6E/ER5wilG+i6K9xYEGHpk4prZwIJaHZWG d1ibRd3G/+H1uaphCsDvWZX9RQT8g70Be9qi1+DJBDrJmQn11cq6MvwMZ9Ro875Ym8o5gS5g== X-Received: by 2002:a17:903:384d:b0:2a0:b62e:e016 with SMTP id d9443c01a7336-2a7175a5dacmr31300375ad.32.1768576328776; Fri, 16 Jan 2026 07:12:08 -0800 (PST) Received: from ?IPV6:2401:4900:647d:8d87:29d8:49f2:6b71:bc64? ([2401:4900:647d:8d87:29d8:49f2:6b71:bc64]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7193fab6esm24234045ad.68.2026.01.16.07.12.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jan 2026 07:12:08 -0800 (PST) Message-ID: Date: Fri, 16 Jan 2026 20:41:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] staging: rtl8723bs: simplify boolean expressions To: Greg KH Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260116053052.4198-1-khushalchitturi@gmail.com> <20260116053052.4198-3-khushalchitturi@gmail.com> <2026011610-aghast-crazed-178a@gregkh> Content-Language: en-US From: Khushal Chitturi In-Reply-To: <2026011610-aghast-crazed-178a@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/16/26 6:41 PM, Greg KH wrote: > On Fri, Jan 16, 2026 at 11:00:50AM +0530, Khushal Chitturi wrote: >> Simplify boolean expressions in rtw_xmit.c to >> comply with the kernel coding style > > Please use the full 72 characters on a line. > >> Signed-off-by: Khushal Chitturi >> >> --- >> Changelog: >> v2 -> v3: Resubmitted as a versioned series to avoid threading confusion. >> v1 -> v2: Corrected commit messages. >> >> drivers/staging/rtl8723bs/core/rtw_xmit.c | 38 ++++++++++++----------- >> 1 file changed, 20 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c >> index bbc42db1c828..97e38ef62ac4 100644 >> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c >> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c >> @@ -384,7 +384,8 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame * >> } else { >> while (true) { >> /* IOT action */ >> - if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && (pattrib->ampdu_en == true) && >> + if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && >> + (pattrib->ampdu_en) && > > You moved this to the next line in the right place, but here: > >> @@ -903,8 +905,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr >> >> if (pattrib->qos_en) >> qos_option = true; >> - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true) || >> - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)) { >> + } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || >> + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { > > You did not? How come? You're right, I missed the alignment in that second block. I will fix it and send a v4. -- Regards, Khushal