From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Phil Auld <pauld@redhat.com>
Cc: mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
kprateek.nayak@amd.com, juri.lelli@redhat.com,
vschneid@redhat.com, dietmar.eggemann@arm.com, tj@kernel.org,
rostedt@goodmis.org, mgorman@suse.de, bsegall@google.com,
arighi@nvidia.com
Subject: Re: [PATCH v2 3/3] sched/fair: Add compile time check in fastpaths for CONFIG_SCHED_SMT=n
Date: Wed, 13 May 2026 09:45:53 +0530 [thread overview]
Message-ID: <be198fb8-8293-442e-a683-035dbbf58a6f@linux.ibm.com> (raw)
In-Reply-To: <20260512165927.GD140541@pauld.westford.csb>
Hi Phil.
On 5/12/26 10:29 PM, Phil Auld wrote:
> Hi Shrikanth,
>
> On Tue, May 12, 2026 at 08:51:25PM +0530 Shrikanth Hegde wrote:
>> For fastpaths such as wakeup, load balance even a minimal code additons
>> can pop up. Add IS_ENABLED checks there to ensure there is no overhead.
>
> "For fastpaths such as wakeup and load balance, even minimal code additions
> can add up. Add IS_ENABLED() checks..." ?
>
Ok.
>>
>> Other places are either have sched_smt_active() check or they are not in
>
> s/are//
ok.
>
> "have a sched_smt_active_check()" or drop "check" ?
>
>
I was saying sched_smt_active() runtime gating is there for many fast paths where
cpu_smt_mask is being referred or those code paths are not fast paths.
Let me re-word a bit.
> Otherwise lgtm.
>
> Reviewed-by: Phil Auld <pauld@redhat.com>
>
>
> Cheers,
> Phil
>
Thanks for the review.
next prev parent reply other threads:[~2026-05-13 4:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 15:21 [PATCH v2 0/3] sched: Simplify ifdeffery around CONFIG_SCHED_SMT Shrikanth Hegde
2026-05-12 15:21 ` [PATCH v2 1/3] topology: Introduce cpu_smt_mask for CONFIG_SCHED_SMT=n Shrikanth Hegde
2026-05-12 16:56 ` Phil Auld
2026-05-12 15:21 ` [PATCH v2 2/3] sched: Simplify ifdeffery around cpu_smt_mask Shrikanth Hegde
2026-05-12 16:57 ` Phil Auld
2026-05-12 15:21 ` [PATCH v2 3/3] sched/fair: Add compile time check in fastpaths for CONFIG_SCHED_SMT=n Shrikanth Hegde
2026-05-12 16:59 ` Phil Auld
2026-05-13 4:15 ` Shrikanth Hegde [this message]
2026-05-13 11:53 ` Phil Auld
2026-05-13 6:07 ` K Prateek Nayak
2026-05-13 6:16 ` Shrikanth Hegde
2026-05-13 6:39 ` Shrikanth Hegde
2026-05-13 6:57 ` K Prateek Nayak
2026-05-12 17:48 ` [PATCH v2 0/3] sched: Simplify ifdeffery around CONFIG_SCHED_SMT Valentin Schneider
2026-05-13 6:20 ` K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be198fb8-8293-442e-a683-035dbbf58a6f@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox