From: Jiri Slaby <jirislaby@kernel.org>
To: Andre Werner <andre.werner@systec-electronic.com>,
gregkh@linuxfoundation.org, hvilleneuve@dimonoff.com,
andy@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
lech.perczak@camlingroup.com
Subject: Re: [PATCH v1] serial: sc16is7xx: Extend IRQ check for negative valus
Date: Thu, 16 Jan 2025 10:42:14 +0100 [thread overview]
Message-ID: <be1bc254-da95-47c2-b81c-e630c0f924b2@kernel.org> (raw)
In-Reply-To: <20250116093203.460215-1-andre.werner@systec-electronic.com>
This is threaded weirdly.
On 16. 01. 25, 10:32, Andre Werner wrote:
> Fix the IRQ check to treat the negative values as No IRQ.
Care to describe on what HW that can happen?
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 7b51cdc274fd..560f45ed19ae 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
> /* Always ask for fixed clock rate from a property. */
> device_property_read_u32(dev, "clock-frequency", &uartclk);
>
> - s->polling = !!irq;
> + s->polling = (irq <= 0);
> if (s->polling)
> dev_dbg(dev,
> "No interrupt pin definition, falling back to polling mode\n");
--
js
suse labs
next prev parent reply other threads:[~2025-01-16 9:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 7:04 [PATCH v7 1/2] dt-bindings: serial: sc16is7xx: Add description for polling mode Andre Werner
2025-01-14 7:04 ` [PATCH v7 2/2] serial: sc16is7xx: Add polling mode if no IRQ pin is available Andre Werner
2025-01-14 14:56 ` Andy Shevchenko
2025-01-15 5:23 ` [External Email] " Andre Werner
2025-01-15 15:08 ` Andy Shevchenko
2025-01-16 8:34 ` [PATCH v7] " Andre Werner
2025-01-16 8:42 ` Andre Werner
2025-01-16 9:03 ` Andy Shevchenko
2025-01-16 9:32 ` [PATCH v1] serial: sc16is7xx: Extend IRQ check for negative valus Andre Werner
2025-01-16 9:42 ` Jiri Slaby [this message]
2025-01-16 9:52 ` [External Email] " Andre Werner
2025-01-16 10:01 ` Jiri Slaby
2025-01-16 12:00 ` Andy Shevchenko
2025-01-16 9:53 ` Andy Shevchenko
2025-01-16 10:02 ` Jiri Slaby
2025-01-16 12:01 ` Andy Shevchenko
2025-01-16 17:13 ` Andy Shevchenko
2025-01-16 9:02 ` [PATCH v7] serial: sc16is7xx: Add polling mode if no IRQ pin is available Andy Shevchenko
2025-01-17 11:50 ` Greg KH
2025-01-17 12:37 ` [External Email] " Andre Werner
2025-01-17 12:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be1bc254-da95-47c2-b81c-e630c0f924b2@kernel.org \
--to=jirislaby@kernel.org \
--cc=andre.werner@systec-electronic.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox