From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B65C6FD1D for ; Tue, 21 Mar 2023 23:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbjCUXxN (ORCPT ); Tue, 21 Mar 2023 19:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjCUXxL (ORCPT ); Tue, 21 Mar 2023 19:53:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05A33900B; Tue, 21 Mar 2023 16:53:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94EF861EE5; Tue, 21 Mar 2023 23:53:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8E6DC433D2; Tue, 21 Mar 2023 23:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679442788; bh=u3FIUoADjtoydcrO6I/aan1rZmbX5WL1LF1a+25+YAU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=h1Hu+DeUR3VZRZVBG2jNUJRWJu0N59GwVNc5RxyKN/BoFepQ+v7/623jG/Ui20DH+ 5VWLZYUaixBqgHl3Rv33CPCTIjYqfRyOKfujqfjP9ssGc8NImR+LbZ6FBNB28+2jGg pcgkiozLHv47BpRX6trD7iM64iSY6v+Zmk9WQRN/YtHKHsfkrMM2TF07MvVmtzpUQH XqssElxcEcxJV+dOkTiV29n9HwVZZCI/eckjHmpOxIPBCT84d9Hh1edGnJIGVECX1m ngKMkmzTKdWqANJ/xjBNfFV3yB3zdhd46RTvxpO6PSnYu0z9cHXm9wYMVQKjNl5VQF rb4islGZnEV8w== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221209152913.1335068-2-marpagan@redhat.com> References: <20221209152913.1335068-1-marpagan@redhat.com> <20221209152913.1335068-2-marpagan@redhat.com> Subject: Re: [PATCH 1/6] clk: socfpga: use of_clk_add_hw_provider and improve error handling From: Stephen Boyd Cc: Marco Pagani , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Dinh Nguyen , Marco Pagani , Michael Turquette Date: Tue, 21 Mar 2023 16:53:05 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marco Pagani (2022-12-09 07:29:08) > The function of_clk_add_provider() has been deprecated, so use its > suggested replacement of_clk_add_hw_provider() instead. >=20 > Since of_clk_add_hw_provider() can fail, like of_clk_add_provider(), > check its return value and do the error handling. >=20 > The indentation of the init function parameters has been aligned > to match open parenthesis, as suggested by checkpatch, and the __init > macro moved before the function name, as specified in init.h. >=20 > Signed-off-by: Marco Pagani > --- Applied to clk-next