From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E38D30C108; Wed, 17 Sep 2025 15:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758122931; cv=none; b=L8SJhcCIjpwBtLDhJmgCYXvHbwE0mfj8EU/ATYm+nBbrs0OCgcV8MNL2iEQLNUZrKgV0oAXBnoC2Kld0sXC0pkvJHhb/OrHZJr5qrZmUiZxbx4DTyT7Hb9nUhHSb6nvP0MtjvnqJw69O6c6RbyJF7f912j2N3q1pxA/qAMqeqJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758122931; c=relaxed/simple; bh=VpoFPhTwmm+WWukzSN7f5WNcO6XoGwtY7ZzuWmn9+lg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lIj46epuP/vULfVrfYv0/xp/Zv0q2Xbhr072O6wcYIiBVNx8eL7G553kWHE3PBuszwamMVgr5OINqe/zRfFlL6JWtbOyOHTDh2Dy7bKUkxxk/wzshz1EjE3I3kxxNvaeF3ADC5kZclh7H6Mlsjp8zubZ0saWdIftEPMGzn4iIPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=VzbT8W8n; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="VzbT8W8n" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C6A821A0E8F; Wed, 17 Sep 2025 15:28:45 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9801A6063E; Wed, 17 Sep 2025 15:28:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BADAB102F1BF4; Wed, 17 Sep 2025 17:28:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1758122924; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=BFIVUZm5xuzuhfpRFg3QFSYuUBaBVnTUcSVoLhOrwf4=; b=VzbT8W8n/UBPmcEza93b9wYmwQXZ05Yy8SthzG0kUy+NcfHlsxg7W9HcgcKVoWjhL7FE2E Outq7VvZEGdkcqxNqc0m1OstRoquJTw6VgFfU88C0LlZdYF7bKL+Av7MxsWzxUPoj4SBW8 8HYzaNOh26u/Au9nqoJ5SiB+kJEAjuP/2tWHEZofJEVISWpoWHcR6eSH138JJDIV7McPjb KNpoefIhS6ZtOlmXqHLo/dOnT8KclXhVjSfTw7zcxk8C5/lP7yagBp38SRAYsA5Tau/o25 J7YpionBrmZnKqLY0gjXfGvbSAgCwiJBGhd7+QH3pYGVtFd8cCMouQ+xrzNDiQ== Message-ID: Date: Wed, 17 Sep 2025 17:28:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v3 01/14] selftests/bpf: test_xsk: Split xskxceiver To: Maciej Fijalkowski Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Thomas Petazzoni , Alexis Lothore , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250904-xsk-v3-0-ce382e331485@bootlin.com> <20250904-xsk-v3-1-ce382e331485@bootlin.com> From: Bastien Curutchet Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Maciej, On 9/16/25 4:21 PM, Maciej Fijalkowski wrote: > On Thu, Sep 04, 2025 at 12:10:16PM +0200, Bastien Curutchet (eBPF Foundation) wrote: >> AF_XDP features are tested by the test_xsk.sh script but not by the >> test_progs framework. The tests used by the script are defined in >> xksxceiver.c which can't be integrated in the test_progs framework as is. >> >> Extract these test definitions from xskxceiver{.c/.h} to put them in new >> test_xsk{.c/.h} files. >> Keep the main() function and its unshared dependencies in xksxceiver to >> avoid impacting the test_xsk.sh script which is often used to test real >> hardware. >> >> Signed-off-by: Bastien Curutchet (eBPF Foundation) >> --- > > Hi Bastien, > > after this patch the way summary is reported is different. > > Before: > # 16 skipped test(s) detected. Consider enabling relevant config options to improve coverage. > # Totals: pass:53 fail:3 xfail:0 xpass:0 skip:16 error:0 > > After: > # Planned tests != run tests (72 != 53) > # Totals: pass:53 fail:0 xfail:0 xpass:0 skip:0 error:0 > > We lose the count of failed tests. Could you take a look? Good catch, I'll take a look at it. Best regards, -- Bastien Curutchet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com