From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] firmware: exynos-acpm: allow use during system shutdown
Date: Tue, 25 Mar 2025 08:57:25 +0100 [thread overview]
Message-ID: <be580155-372f-445b-b9d1-2dc4fbf1c3a1@kernel.org> (raw)
In-Reply-To: <20250324-acpm-atomic-v2-2-7d87746e1765@linaro.org>
On 24/03/2025 16:34, André Draszik wrote:
> +static bool acpm_may_sleep(void)
> +{
> + return system_state <= SYSTEM_RUNNING ||
> + (IS_ENABLED(CONFIG_PREEMPT_COUNT) ? preemptible() : !irqs_disabled());
> +}
> +
> /**
> * acpm_dequeue_by_polling() - RX dequeue by polling.
> * @achan: ACPM channel info.
> @@ -300,7 +314,10 @@ static int acpm_dequeue_by_polling(struct acpm_chan *achan,
> return 0;
>
> /* Determined experimentally. */
> - usleep_range(20, 30);
> + if (!acpm_may_sleep())
> + udelay(10);
> + else
... and what do you do if IRQs get disabled exactly in this moment? This
is just racy. You cannot check for a condition and assume it will be
valid for whatever time you want it to be valid.
What happens if system_state is changed to shutdown in this particular
moment? How did you prevent this from happening?
> + usleep_range(20, 30);
> } while (ktime_before(ktime_get(), timeout));
>
> dev_err(dev, "Timeout! ch:%u s:%u bitmap:%lx.\n",
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-25 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 15:34 [PATCH v2 0/2] firmware: exynos-acpm: allow use during system shutdown André Draszik
2025-03-24 15:34 ` [PATCH v2 1/2] firmware: exynos-acpm: use ktime APIs for timeout detection André Draszik
2025-03-24 15:34 ` [PATCH v2 2/2] firmware: exynos-acpm: allow use during system shutdown André Draszik
2025-03-25 7:57 ` Krzysztof Kozlowski [this message]
2025-03-25 8:01 ` André Draszik
2025-03-25 8:07 ` Krzysztof Kozlowski
2025-03-26 7:24 ` Tudor Ambarus
2025-03-26 7:36 ` Krzysztof Kozlowski
2025-03-26 9:15 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be580155-372f-445b-b9d1-2dc4fbf1c3a1@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox