From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754938AbdCJBnj (ORCPT ); Thu, 9 Mar 2017 20:43:39 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:33255 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932159AbdCJBnf (ORCPT ); Thu, 9 Mar 2017 20:43:35 -0500 Subject: Re: [PATCH v2 net 4/8] net: bcmgenet: power down internal phy if open or resume fails To: Doug Berger References: <20170310005850.10808-1-opendmb@gmail.com> <20170310005850.10808-5-opendmb@gmail.com> Cc: pgynther@google.com, jaedon.shin@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: Date: Thu, 9 Mar 2017 17:43:32 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170310005850.10808-5-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2017 04:58 PM, Doug Berger wrote: > Since the internal PHY is powered up during the open and resume > functions it should be powered back down if the functions fail. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian