From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755214AbdBGNFe (ORCPT ); Tue, 7 Feb 2017 08:05:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:38887 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754166AbdBGNFc (ORCPT ); Tue, 7 Feb 2017 08:05:32 -0500 Subject: Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits To: Arnd Bergmann , Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" References: <20170207125948.490095-1-arnd@arndb.de> Cc: Raghava Aditya Renukunta , Dave Carroll , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Johannes Thumshirn Message-ID: Date: Tue, 7 Feb 2017 14:05:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170207125948.490095-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2017 01:59 PM, Arnd Bergmann wrote: > Shifting a dma_addr_t right by 32 bits causes a compile-time warning when > that type is only 32 bit wide: > > drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': > drivers/scsi/aacraid/src.c:414:29: error: right shift count >= width of type [-Werror=shift-count-overflow] > > This changes the driver to use the predefined macros consistently, including > one correct but open-coded upper_32_bits() instance. > > Fixes: d1ef4da8487f ("scsi: aacraid: added support for init_struct_8") > Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface") > Signed-off-by: Arnd Bergmann > --- The coolest thing with your patches is, one gets to know new cool functions/macros. Anyways looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850