From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout11.his.huawei.com (canpmsgout11.his.huawei.com [113.46.200.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE562FD67A for ; Fri, 21 Nov 2025 09:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763717099; cv=none; b=dgBKRXrAOFkqzKDUmSzkGePXOs+REq4i5AqXEJLt7imAoLovIDQnhS/vry4luiQiay4xaWbd6OWVfoJdz+rvsUAk6CKykP0r5b57x6fiRIIJhJzpU5PHfNSPf1Pm1rDOMquFvIdoC+/joktMpgODXKP+F3W58AZXUopLIndRLAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763717099; c=relaxed/simple; bh=Jez8+EyYt/F9yYnqPJ7X/tOZPmkWxBkdFXowQFAOpRw=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ITP7ZOryHAPoS2qZ5BBBVLNpokOtWlET2GiDU4RufUW0H2yfmQQr/9kMKXp9lPTdatFP/o8oCJ6kiYNRx8Sd8p3fQ/V3B6Hr6767buaVvCL5sFAhYhW60G8HcjQCjyOgcXPNM9dmu7gRdXmssS8oZ8BOEzB22WD4ei8KRWWU5VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=SrNSHmDx; arc=none smtp.client-ip=113.46.200.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="SrNSHmDx" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=UdxRi4JTzFkZn/kZqJCUXukEalb3NfL9CcwO64QkNIE=; b=SrNSHmDxRS/A1/qhWQfvVy8MlzbJy8znYx2EQGAorJ1xfnmAdqt9SeTwF/wZ2mMpBdZGV30qr wXixYNlBsmDTpMLDRCwsJuziqXzOZlYUnLHv1Rm3TZgpDI9lzpaLYFNsqcZ554I3pa3fF3xpXgl mukgdYjYVa7vYtVWm5Qhkek= Received: from mail.maildlp.com (unknown [172.19.163.44]) by canpmsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4dCVBP1B1FzKm5S; Fri, 21 Nov 2025 17:23:09 +0800 (CST) Received: from dggemv705-chm.china.huawei.com (unknown [10.3.19.32]) by mail.maildlp.com (Postfix) with ESMTPS id B9B99140295; Fri, 21 Nov 2025 17:24:54 +0800 (CST) Received: from kwepemq100007.china.huawei.com (7.202.195.175) by dggemv705-chm.china.huawei.com (10.3.19.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 21 Nov 2025 17:24:52 +0800 Received: from [10.159.166.136] (10.159.166.136) by kwepemq100007.china.huawei.com (7.202.195.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 21 Nov 2025 17:24:52 +0800 Message-ID: Date: Fri, 21 Nov 2025 17:24:51 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 drm-dp 1/4] drm/hisilicon/hibmc: fix dp probabilistical detect errors after HPD irq To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , References: <20250926011500.2545817-1-shiyongbang@huawei.com> <20250926011500.2545817-2-shiyongbang@huawei.com> From: Yongbang Shi In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemq100007.china.huawei.com (7.202.195.175) Hi Dmitry, I'm replying here to follow up on this patch. It has been a while since your RB, so I just want to check if there are any problems here for my patch, or anything I can do better before it can be picked up? Thanks, Baihan > On Fri, Sep 26, 2025 at 09:14:57AM +0800, Yongbang Shi wrote: >> From: Baihan Li >> >> The issue is that drm_connector_helper_detect_from_ddc() returns wrong >> status when plugging or unplugging the monitor. Use HPD pin status in >> DP's detect_ctx() for real physcal monitor in/out, and implementation >> a complete DP detection including read DPCD, check if it's a branch >> device and its sink count for different situations. >> >> Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature") >> Signed-off-by: Baihan Li >> Signed-off-by: Yongbang Shi >> --- >> ChangeLog: >> v7 -> v8: >> - fix build errors reported by kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202509241625.o4mNleVb-lkp@intel.com/ >> v6 -> v7: >> - add the check about branch devices, suggested by Dmitry Baryshkov. >> v5 -> v6: >> - use HPD status in DP detect_ctx(), suggested by Dmitry Baryshkov. >> v4 -> v5: >> - fix the commit message and DP detect_ctx(), suggested by Dmitry Baryshkov. >> --- >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 4 ++ >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 12 +++++ >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 6 +++ >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 3 ++ >> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 48 ++++++++++++++++++- >> 5 files changed, 71 insertions(+), 2 deletions(-) >> > Reviewed-by: Dmitry Baryshkov > >