From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934144AbcHYNkl (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 09:40:41 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:61951 "EHLO
        mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753343AbcHYNkk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 09:40:40 -0400
X-AuditID: cbfec7f5-f792e6d0000013f5-fe-57bef22cd148
Subject: Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external
 MCLKn clocks
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
References: <1471627036-19465-1-git-send-email-s.nawrocki@samsung.com>
 <20160822092233.GN21682@localhost.localdomain>
 <d47e7106-037f-b40c-71e5-099ee30874e6@samsung.com>
 <20160823162825.GO21682@localhost.localdomain>
 <6b1626c1-d223-4e39-8065-a7421bd3944c@samsung.com>
 <20160825130234.GQ21682@localhost.localdomain>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-id: <bec76144-9dd1-4b67-ea17-0a0a2e190b91@samsung.com>
Date: Thu, 25 Aug 2016 15:26:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-version: 1.0
In-reply-to: <20160825130234.GQ21682@localhost.localdomain>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xK7o6n/aFG3yfx2xx5eIhJoupD5+w
        WfybcoPd4v7Xo4wWl3fNYXNg9djwuYnNY9OqTjaPO9f2sHm8nPibzePzJrkA1igum5TUnMyy
        1CJ9uwSujI4fE5kLprJX7Plzh6mB8QRrFyMnh4SAicSaH19ZIGwxiQv31rN1MXJxCAksZZRo
        O9bLCOE8Z5TY8uEjO0iVsECkxOKln9hAbBEBC4kpS24xQxQdZpJ4f7SLGSTBLJApca5jI5jN
        JmAo0Xu0jxHE5hWwk5gw6RLYIBYBVYldl+6D2aICERK3Vn2EqhGU+DH5HthJnALWEs9+zAKq
        4QCaqSdx/6IWxHh5ic1r3jJPYBSYhaRjFkLVLCRVCxiZVzGKppYmFxQnpeca6RUn5haX5qXr
        JefnbmKEBPTXHYxLj1kdYhTgYFTi4d2xam+4EGtiWXFl7iFGCQ5mJRFey4/7woV4UxIrq1KL
        8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXAuEvni5B6ebI4Z1H6wYmb
        l/902z9N6/5iG52kxsTIxAv/A5w7fKblTRLxd1i77rxUl+cs7j2SCcvPPmOsv/Fpw2a3ybu0
        f+oY5XpIr/X2reYodDprXev5wnJz5jHdhPWXzGQvReQsNH/Z0Wehtjy8JWyC+B2Rx1q22zL6
        /MX9PW2U7h3OYp6lxFKckWioxVxUnAgAiXQGZmQCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/25/2016 03:02 PM, Charles Keepax wrote:
> Yes so the MCLK needs to be available before we start the FLL, so
> my thinking was we would enable the clock that corresponds
> to the source for the FLL in arizona_set_fll before we start
> enabling the FLL.
> 
> The direct MCLK would require a little more work but we could
> probably enable the clock in this case from wm5110_sysclk_ev.
> 
> I have sent you through a copy of my prototype clock patches you
> can have a look at. I am going to have a bit of a look over this
> today and hopefully will be able to get back to you with more
> concrete thoughts later today.

Thanks, I will have a closer look at the patches.

I have hard coded the MCLK frequency in the tm2_wm511 machine driver
as its fixed anyway and now if the MCLK gating was taken care of by
the CODEC we wouldn't need at all to get at the MCLK clocks in the
machine driver.