Re: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock on panic path

Guilherme G. Piccoli
2022-05-23T21:56:17Z

On 23/05/2022 18:31, Helge Deller wrote:
> Hello Guilherme,
>
> On 5/23/22 22:40, Guilherme G. Piccoli wrote:
>> On 28/04/2022 13:55, Helge Deller wrote:
>>> [...]
>>> You may add:
>>> Acked-by: Helge Deller <deller@gmx.de> # parisc
>>
>> Hi Helge, do you think would be possible to still pick this one for
>> v5.19 or do you prefer to hold for the next release?
>
> Actually, I'd prefer if you push this patch together with the whole
> series upstream at once. The patch itself makes not much sense without
> your series...
>
>> I'm working on V2, so if it's merged for 5.19 I won't send it again.
>
> Helge

Sure Helge, I guess I can do that - will resubmit for V2.

But notice the patch is self-contained, as it fixes a current issue in
the code - the risk for a lockup due to spinlock taking on atomic
context. It doesn't require the panic refactor to be merged in order to
achieve its goal...

I agree that such issue is rare to trigger though, so definitely no
hurry is needed =)

Cheers,

Guilherme