From: Yanteng Si <si.yanteng@linux.dev>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Huacai Chen <chenhuacai@loongson.cn>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Serge Semin <fancer.lancer@gmail.com>,
loongarch@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
Date: Mon, 2 Feb 2026 15:43:01 +0800 [thread overview]
Message-ID: <bef6065d-57d6-4b88-aa7e-ece766107892@linux.dev> (raw)
In-Reply-To: <CAAhV-H5T=1FefitLWSf5Qw3HEwFO0ERhefq1udae6mt9tq+ikQ@mail.gmail.com>
在 2026/2/2 15:29, Huacai Chen 写道:
> On Mon, Feb 2, 2026 at 9:36 AM Yanteng Si <si.yanteng@linux.dev> wrote:
>>
>> 在 2026/2/1 10:36, Huacai Chen 写道:
>>> In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
>>> so correct it.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>> fix tag?
>>
>> But this is just a comment, no need to backport it (I'm fine either way).
>>
>> If no fix tag, please update the subject to typo fix instead.
> Why? Is the subject line wrong?
You're absolutely right, and "typo" specifically refers to a typographical
error in written content—this patch is a correction to a comment, so using
"typo" is perfectly appropriate.
I might be misinterpreting the wording here – what I really want is to tell
exactly what a patch modifies from the subject alone, without having to
check the patch content. Maybe "correct comment" is a better fit. I know
I'm splitting hairs a bit, but I couldn't just stay silent after receiving your
patch, right?
Thanks,
Yanteng
>
> Huacai
>
>>
>> Thanks,
>>
>> Yanteng
>>
>>
>>
next prev parent reply other threads:[~2026-02-02 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 2:36 [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i Huacai Chen
2026-02-01 4:43 ` Yao Zi
2026-02-01 7:19 ` Huacai Chen
2026-02-02 1:36 ` Yanteng Si
2026-02-02 7:29 ` Huacai Chen
2026-02-02 7:43 ` Yanteng Si [this message]
2026-02-03 0:07 ` Jakub Kicinski
2026-02-03 2:48 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bef6065d-57d6-4b88-aa7e-ece766107892@linux.dev \
--to=si.yanteng@linux.dev \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox