public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yanfei Xu <yanfei.xu@intel.com>
To: Tina Zhang <tina.zhang@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Kevin Tian" <kevin.tian@intel.com>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Michael Shavit <mshavit@google.com>
Cc: <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 5/6] iommu: Support mm PASID 1:1 with sva domain
Date: Mon, 17 Jul 2023 16:47:45 +0800	[thread overview]
Message-ID: <bef8be2b-2d37-b00f-42fb-40887aac27a1@intel.com> (raw)
In-Reply-To: <20230707013441.365583-6-tina.zhang@intel.com>

Hi Tina,

On 7/7/2023 9:34 AM, Tina Zhang wrote:
> @@ -33,9 +34,18 @@ static int iommu_sva_alloc_pasid(struct mm_struct *mm, ioasid_t min, ioasid_t ma
>   		goto out;
>   	}
>   
> +	iommu_mm = kzalloc(sizeof(struct iommu_mm_data), GFP_KERNEL);
> +	if (!iommu_mm) {
> +		ret = -ENOMEM;
> +		goto out;
> +	}
> +	mm->iommu_mm = iommu_mm;
> +
>   	ret = ida_alloc_range(&iommu_global_pasid_ida, min, max, GFP_KERNEL);
> -	if (ret < min)
> +	if (ret < min) {
> +		kfree(iommu_mm);
>   		goto out;

Once pasid allocation fails at this part, we should reassign the 
mm->iommu_mm back to default value, or it will keep a unavailable 
pointer, right?

Thanks,
Yanfei
> +	}
>   	mm_set_pasid(mm, ret);
>   	ret = 0;
>   out:

  parent reply	other threads:[~2023-07-17  8:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07  1:34 [RFC PATCH 0/6] Share sva domain with all devices bound to a mm Tina Zhang
2023-07-07  1:34 ` [RFC PATCH 1/6] iommu: Add two pasid helper functions Tina Zhang
2023-07-07  1:34 ` [RFC PATCH 2/6] iommu: Call helper functions to get/set assigned pasid value Tina Zhang
2023-07-07  1:34 ` [RFC PATCH 3/6] iommu: Introduce struct iommu_mm_data Tina Zhang
2023-07-07  1:34 ` [RFC PATCH 4/6] mm: Add iommu_mm field to mm_struct Tina Zhang
2023-07-07  1:34 ` [RFC PATCH 5/6] iommu: Support mm PASID 1:1 with sva domain Tina Zhang
2023-07-10 17:28   ` Jason Gunthorpe
2023-07-11  1:42     ` Zhang, Tina
2023-07-11  2:43     ` Baolu Lu
2023-07-11 14:18       ` Jason Gunthorpe
2023-07-17  8:47   ` Yanfei Xu [this message]
2023-07-07  1:34 ` [RFC PATCH 6/6] mm: Deprecate pasid field Tina Zhang
2023-07-10 17:29   ` Jason Gunthorpe
2023-07-11  1:46     ` Zhang, Tina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bef8be2b-2d37-b00f-42fb-40887aac27a1@intel.com \
    --to=yanfei.xu@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mshavit@google.com \
    --cc=tina.zhang@intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox