linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC
@ 2025-06-20 15:40 Max Shevchenko via B4 Relay
  2025-06-20 15:40 ` [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572 Max Shevchenko via B4 Relay
                   ` (11 more replies)
  0 siblings, 12 replies; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

This series of patches adds support for the MT6572 SoC and
the JTY D101 tablet and Lenovo A369i smartphone based on it.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
Max Shevchenko (11):
      dt-bindings: serial: mediatek,uart: add MT6572
      dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: add MT6572
      dt-bindings: timer: mediatek: add MT6572
      dt-bindings: watchdog: mediatek,mtk-wdt: add MT6572
      dt-bindings: vendor-prefixes: add JTY
      dt-bindings: arm: mediatek: add boards based on the MT6572 SoC
      ARM: mediatek: show the hardware name for the MT6572
      ARM: mediatek: add MT6572 smp bring up code
      ARM: dts: mediatek: add basic support for MT6572 SoC
      ARM: dts: mediatek: add basic support for JTY D101 board
      ARM: dts: mediatek: add basic support for Lenovo A369i board

 .../devicetree/bindings/arm/mediatek.yaml          |   5 +
 .../mediatek,mt6577-sysirq.yaml                    |   1 +
 .../devicetree/bindings/serial/mediatek,uart.yaml  |   1 +
 .../devicetree/bindings/timer/mediatek,timer.yaml  |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
 .../bindings/watchdog/mediatek,mtk-wdt.yaml        |   1 +
 arch/arm/boot/dts/mediatek/Makefile                |   2 +
 arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts     |  62 ++++++++++++
 arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts |  57 +++++++++++
 arch/arm/boot/dts/mediatek/mt6572.dtsi             | 105 +++++++++++++++++++++
 arch/arm/mach-mediatek/Kconfig                     |   4 +
 arch/arm/mach-mediatek/mediatek.c                  |   1 +
 arch/arm/mach-mediatek/platsmp.c                   |   7 ++
 13 files changed, 249 insertions(+)
---
base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
change-id: 20250619-mt6572-ef78a3d45168

Best regards,
-- 
Max Shevchenko <wctrl@proton.me>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  6:11   ` Krzysztof Kozlowski
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 02/11] dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: " Max Shevchenko via B4 Relay
                   ` (10 subsequent siblings)
  11 siblings, 2 replies; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add a compatible string for serial on the MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 Documentation/devicetree/bindings/serial/mediatek,uart.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/mediatek,uart.yaml b/Documentation/devicetree/bindings/serial/mediatek,uart.yaml
index 1b02f0b197ff46e3530372d1d9303210cca9c2d5..fe283494188dea64bdfdd34a781bf54c8cbc1f05 100644
--- a/Documentation/devicetree/bindings/serial/mediatek,uart.yaml
+++ b/Documentation/devicetree/bindings/serial/mediatek,uart.yaml
@@ -25,6 +25,7 @@ properties:
           - enum:
               - mediatek,mt2701-uart
               - mediatek,mt2712-uart
+              - mediatek,mt6572-uart
               - mediatek,mt6580-uart
               - mediatek,mt6582-uart
               - mediatek,mt6589-uart

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 02/11] dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: add MT6572
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
  2025-06-20 15:40 ` [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572 Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 03/11] dt-bindings: timer: mediatek: " Max Shevchenko via B4 Relay
                   ` (9 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add a compatible string for sysirq on the MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 .../devicetree/bindings/interrupt-controller/mediatek,mt6577-sysirq.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/mediatek,mt6577-sysirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/mediatek,mt6577-sysirq.yaml
index 123d24b05556c67374fbb87abe5e16c65031d2ed..30d76692ca87b507900076cd2f7d2e7ed2605b33 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/mediatek,mt6577-sysirq.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/mediatek,mt6577-sysirq.yaml
@@ -21,6 +21,7 @@ properties:
           - enum:
               - mediatek,mt2701-sysirq
               - mediatek,mt2712-sysirq
+              - mediatek,mt6572-sysirq
               - mediatek,mt6580-sysirq
               - mediatek,mt6582-sysirq
               - mediatek,mt6589-sysirq

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 03/11] dt-bindings: timer: mediatek: add MT6572
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
  2025-06-20 15:40 ` [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572 Max Shevchenko via B4 Relay
  2025-06-20 15:40 ` [PATCH 02/11] dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: " Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 04/11] dt-bindings: watchdog: mediatek,mtk-wdt: " Max Shevchenko via B4 Relay
                   ` (8 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add a compatible string for timer on the MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 Documentation/devicetree/bindings/timer/mediatek,timer.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/mediatek,timer.yaml b/Documentation/devicetree/bindings/timer/mediatek,timer.yaml
index f68fc7050c5687930e2ca6b6fa8f0b7a208803da..d5b574bfd2caad1bc54ef6bd1768d94055383727 100644
--- a/Documentation/devicetree/bindings/timer/mediatek,timer.yaml
+++ b/Documentation/devicetree/bindings/timer/mediatek,timer.yaml
@@ -26,6 +26,7 @@ properties:
       - items:
           - enum:
               - mediatek,mt2701-timer
+              - mediatek,mt6572-timer
               - mediatek,mt6580-timer
               - mediatek,mt6582-timer
               - mediatek,mt6589-timer

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 04/11] dt-bindings: watchdog: mediatek,mtk-wdt: add MT6572
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (2 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 03/11] dt-bindings: timer: mediatek: " Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 05/11] dt-bindings: vendor-prefixes: add JTY Max Shevchenko via B4 Relay
                   ` (7 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add a compatible string for watchdog on the MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
index 8d2520241e37f0e8a7526cbc99d5aa0d4edc9a55..ba0bfd73ab62a86befead007d4b7d2a870b81a0c 100644
--- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
@@ -34,6 +34,7 @@ properties:
       - items:
           - enum:
               - mediatek,mt2701-wdt
+              - mediatek,mt6572-wdt
               - mediatek,mt6582-wdt
               - mediatek,mt6797-wdt
               - mediatek,mt7622-wdt

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 05/11] dt-bindings: vendor-prefixes: add JTY
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (3 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 04/11] dt-bindings: watchdog: mediatek,mtk-wdt: " Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 06/11] dt-bindings: arm: mediatek: add boards based on the MT6572 SoC Max Shevchenko via B4 Relay
                   ` (6 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

JTY produced low-cost Android tablets based on various
MediaTek MT65xx SoCs.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 86f6a19b28ae217643bf7a63a471f74819d18238..517bd129288c96483ffe358127ce8e16f60d902b 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -782,6 +782,8 @@ patternProperties:
     description: Jide Tech
   "^joz,.*":
     description: JOZ BV
+  "^jty,.*":
+    description: JTY
   "^kam,.*":
     description: Kamstrup A/S
   "^karo,.*":

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 06/11] dt-bindings: arm: mediatek: add boards based on the MT6572 SoC
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (4 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 05/11] dt-bindings: vendor-prefixes: add JTY Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 07/11] ARM: mediatek: show the hardware name for the MT6572 Max Shevchenko via B4 Relay
                   ` (5 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add entries for the JTY D101 tablet and the Lenovo A369i smartphone.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 108ae5e0185d93976556a03768595961961bcc33..d5cb133b8a75fb5325f201f10c83bbe434a1da89 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -27,6 +27,11 @@ properties:
           - enum:
               - mediatek,mt2712-evb
           - const: mediatek,mt2712
+      - items:
+          - enum:
+              - jty,d101
+              - lenovo,a369i
+          - const: mediatek,mt6572
       - items:
           - enum:
               - mediatek,mt6580-evbp1

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 07/11] ARM: mediatek: show the hardware name for the MT6572
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (5 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 06/11] dt-bindings: arm: mediatek: add boards based on the MT6572 SoC Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 08/11] ARM: mediatek: add MT6572 smp bring up code Max Shevchenko via B4 Relay
                   ` (4 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add a compatible string for the MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 arch/arm/mach-mediatek/mediatek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
index e6e9f93a1f01c7d043cf4312b9406b25c8897198..5c28124bd0078b31665fef647e496f4131b82c8d 100644
--- a/arch/arm/mach-mediatek/mediatek.c
+++ b/arch/arm/mach-mediatek/mediatek.c
@@ -38,6 +38,7 @@ static void __init mediatek_timer_init(void)
 
 static const char * const mediatek_board_dt_compat[] = {
 	"mediatek,mt2701",
+	"mediatek,mt6572",
 	"mediatek,mt6589",
 	"mediatek,mt6592",
 	"mediatek,mt7623",

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 08/11] ARM: mediatek: add MT6572 smp bring up code
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (6 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 07/11] ARM: mediatek: show the hardware name for the MT6572 Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (3 subsequent siblings)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add support for booting the secondary CPU on the MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 arch/arm/mach-mediatek/Kconfig   | 4 ++++
 arch/arm/mach-mediatek/platsmp.c | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
index 35a3430c7942d897106bb32916df78347113798a..638eabad2dd37ee56244fc036cb76af135aee416 100644
--- a/arch/arm/mach-mediatek/Kconfig
+++ b/arch/arm/mach-mediatek/Kconfig
@@ -15,6 +15,10 @@ config MACH_MT2701
 	bool "MediaTek MT2701 SoCs support"
 	default ARCH_MEDIATEK
 
+config MACH_MT6572
+	bool "MediaTek MT6572 SoCs support"
+	default ARCH_MEDIATEK
+
 config MACH_MT6589
 	bool "MediaTek MT6589 SoCs support"
 	default ARCH_MEDIATEK
diff --git a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c
index 16a4ee6c959050474c5535ac6a65d92b29482d53..bbd26d423bdef23629ec5ca9d9c61903748988b7 100644
--- a/arch/arm/mach-mediatek/platsmp.c
+++ b/arch/arm/mach-mediatek/platsmp.c
@@ -29,6 +29,12 @@ static const struct mtk_smp_boot_info mtk_mt8135_tz_boot = {
 	{ 0x3f8, 0x3f8, 0x3f8 },
 };
 
+static const struct mtk_smp_boot_info mtk_mt6572_boot = {
+	0x10001400, 0x08,
+	{ 0x534c4131 },
+	{ 0x0c },
+};
+
 static const struct mtk_smp_boot_info mtk_mt6589_boot = {
 	0x10002000, 0x34,
 	{ 0x534c4131, 0x4c415332, 0x41534c33 },
@@ -49,6 +55,7 @@ static const struct of_device_id mtk_tz_smp_boot_infos[] __initconst = {
 };
 
 static const struct of_device_id mtk_smp_boot_infos[] __initconst = {
+	{ .compatible   = "mediatek,mt6572", .data = &mtk_mt6572_boot },
 	{ .compatible   = "mediatek,mt6589", .data = &mtk_mt6589_boot },
 	{ .compatible   = "mediatek,mt7623", .data = &mtk_mt7623_boot },
 	{ .compatible   = "mediatek,mt7629", .data = &mtk_mt7623_boot },

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (7 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 08/11] ARM: mediatek: add MT6572 smp bring up code Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  6:12   ` Krzysztof Kozlowski
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-20 15:40 ` [PATCH 10/11] ARM: dts: mediatek: add basic support for JTY D101 board Max Shevchenko via B4 Relay
                   ` (2 subsequent siblings)
  11 siblings, 2 replies; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

Add basic support for the MediaTek MT6572 SoC.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 arch/arm/boot/dts/mediatek/mt6572.dtsi | 105 +++++++++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)

diff --git a/arch/arm/boot/dts/mediatek/mt6572.dtsi b/arch/arm/boot/dts/mediatek/mt6572.dtsi
new file mode 100644
index 0000000000000000000000000000000000000000..dd12231ca745be7455e99391abd2d708f2f1a8a9
--- /dev/null
+++ b/arch/arm/boot/dts/mediatek/mt6572.dtsi
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2025 Max Shevchenko <wctrl@proton.me>
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "mediatek,mt6572";
+	interrupt-parent = <&sysirq>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		enable-method = "mediatek,mt6589-smp";
+
+		cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x0>;
+		};
+		cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x1>;
+		};
+	};
+
+	system_clk: dummy13m {
+		compatible = "fixed-clock";
+		clock-frequency = <13000000>;
+		#clock-cells = <0>;
+	};
+
+	rtc_clk: dummy32k {
+		compatible = "fixed-clock";
+		clock-frequency = <32000>;
+		#clock-cells = <0>;
+	};
+
+	uart_clk: dummy26m {
+		compatible = "fixed-clock";
+		clock-frequency = <26000000>;
+		#clock-cells = <0>;
+	};
+
+	watchdog: watchdog@10007000 {
+		compatible = "mediatek,mt6572-wdt",
+			     "mediatek,mt6589-wdt";
+		reg = <0x10007000 0x100>;
+		interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_LOW>;
+		timeout-sec = <15>;
+		#reset-cells = <1>;
+	};
+
+	timer: timer@10008000 {
+		compatible = "mediatek,mt6572-timer",
+			     "mediatek,mt6577-timer";
+		reg = <0x10008000 0x80>;
+		interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
+		clocks = <&system_clk>, <&rtc_clk>;
+		clock-names = "system-clk", "rtc-clk";
+	};
+
+	sysirq: interrupt-controller@10200100 {
+		compatible = "mediatek,mt6572-sysirq",
+			     "mediatek,mt6577-sysirq";
+		interrupt-controller;
+		#interrupt-cells = <3>;
+		interrupt-parent = <&gic>;
+		reg = <0x10200100 0x1c>;
+	};
+
+	gic: interrupt-controller@10211000 {
+		compatible = "arm,cortex-a7-gic";
+		interrupt-controller;
+		#interrupt-cells = <3>;
+		interrupt-parent = <&gic>;
+		reg = <0x10211000 0x1000>,
+		      <0x10212000 0x2000>,
+		      <0x10214000 0x2000>,
+		      <0x10216000 0x2000>;
+	};
+
+	uart0: serial@11005000 {
+		compatible = "mediatek,mt6572-uart",
+			     "mediatek,mt6577-uart";
+		reg = <0x11005000 0x400>;
+		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_LOW>;
+		clocks = <&uart_clk>;
+		status = "disabled";
+	};
+
+	uart1: serial@11006000 {
+		compatible = "mediatek,mt6572-uart",
+			     "mediatek,mt6577-uart";
+		reg = <0x11006000 0x400>;
+		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+		clocks = <&uart_clk>;
+		status = "disabled";
+	};
+};

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 10/11] ARM: dts: mediatek: add basic support for JTY D101 board
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (8 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  6:12   ` Krzysztof Kozlowski
  2025-06-20 15:40 ` [PATCH 11/11] ARM: dts: mediatek: add basic support for Lenovo A369i board Max Shevchenko via B4 Relay
  2025-06-23  2:39 ` [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Rob Herring (Arm)
  11 siblings, 1 reply; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

This tablet uses a MediaTek MT6572 system-on-chip with 1GB of RAM.
It can currently boot into initramfs with a working UART and
Simple Framebuffer using already initialized panel by the bootloader.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 arch/arm/boot/dts/mediatek/Makefile            |  1 +
 arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts | 62 ++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)

diff --git a/arch/arm/boot/dts/mediatek/Makefile b/arch/arm/boot/dts/mediatek/Makefile
index 1957947cb41ce86ed101466bf822d4e2dfdfbb61..cb869a1aaec21a1d99f7f2a829b84672a3f52726 100644
--- a/arch/arm/boot/dts/mediatek/Makefile
+++ b/arch/arm/boot/dts/mediatek/Makefile
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_MEDIATEK) += \
 	mt2701-evb.dtb \
+	mt6572-jty-d101.dtb \
 	mt6580-evbp1.dtb \
 	mt6582-prestigio-pmt5008-3g.dtb \
 	mt6589-aquaris5.dtb \
diff --git a/arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts b/arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts
new file mode 100644
index 0000000000000000000000000000000000000000..5c3b9833073e43fb42e28719c1f206e8884b5f6a
--- /dev/null
+++ b/arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts
@@ -0,0 +1,62 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2025 Max Shevchenko <wctrl@proton.me>
+ */
+
+/dts-v1/;
+#include "mt6572.dtsi"
+
+/ {
+	model = "JTY D101";
+	compatible = "jty,d101", "mediatek,mt6572";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		stdout-path = "serial0:921600n8";
+
+		framebuffer: framebuffer@bf400000 {
+			compatible = "simple-framebuffer";
+			memory-region = <&framebuffer_reserved>;
+			width = <1024>;
+			height = <600>;
+			stride = <(1024 * 2)>;
+			format = "r5g6b5";
+			status = "okay";
+		};
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		connsys@80000000 {
+			reg = <0x80000000 0x100000>;
+			no-map;
+		};
+
+		modem@be000000 {
+			reg = <0xbe000000 0x1400000>;
+			no-map;
+		};
+
+		framebuffer_reserved: framebuffer@bf400000 {
+			reg = <0xbf400000 0xc00000>;
+			no-map;
+		};
+	};
+};
+
+&uart0 {
+	status = "okay";
+};

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [PATCH 11/11] ARM: dts: mediatek: add basic support for Lenovo A369i board
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (9 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 10/11] ARM: dts: mediatek: add basic support for JTY D101 board Max Shevchenko via B4 Relay
@ 2025-06-20 15:40 ` Max Shevchenko via B4 Relay
  2025-06-23  2:39 ` [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Rob Herring (Arm)
  11 siblings, 0 replies; 26+ messages in thread
From: Max Shevchenko via B4 Relay @ 2025-06-20 15:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog, Max Shevchenko

From: Max Shevchenko <wctrl@proton.me>

This smartphone uses a MediaTek MT6572 system-on-chip with 512MB of RAM.
It can currently boot into initramfs with a working UART and
Simple Framebuffer using already initialized panel by the bootloader.

Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
 arch/arm/boot/dts/mediatek/Makefile                |  1 +
 arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts | 57 ++++++++++++++++++++++
 2 files changed, 58 insertions(+)

diff --git a/arch/arm/boot/dts/mediatek/Makefile b/arch/arm/boot/dts/mediatek/Makefile
index cb869a1aaec21a1d99f7f2a829b84672a3f52726..e48de3efeb3b9ab00108cc28afa8da525d0ec14a 100644
--- a/arch/arm/boot/dts/mediatek/Makefile
+++ b/arch/arm/boot/dts/mediatek/Makefile
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_MEDIATEK) += \
 	mt2701-evb.dtb \
 	mt6572-jty-d101.dtb \
+	mt6572-lenovo-a369i.dtb \
 	mt6580-evbp1.dtb \
 	mt6582-prestigio-pmt5008-3g.dtb \
 	mt6589-aquaris5.dtb \
diff --git a/arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts b/arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts
new file mode 100644
index 0000000000000000000000000000000000000000..da8865a6b7e4f0e346f42504b3f8a4db61cb240e
--- /dev/null
+++ b/arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2025 Max Shevchenko <wctrl@proton.me>
+ */
+
+/dts-v1/;
+#include "mt6572.dtsi"
+
+/ {
+	model = "Lenovo A369i";
+	compatible = "lenovo,a369i", "mediatek,mt6572";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		stdout-path = "serial0:921600n8";
+
+		framebuffer: framebuffer@9fa00000 {
+			compatible = "simple-framebuffer";
+			memory-region = <&framebuffer_reserved>;
+			width = <480>;
+			height = <800>;
+			stride = <(480 * 2)>;
+			format = "r5g6b5";
+			status = "okay";
+		};
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x20000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		connsys@80000000 {
+			reg = <0x80000000 0x100000>;
+			no-map;
+		};
+
+		framebuffer_reserved: framebuffer@9fa00000 {
+			reg = <0x9fa00000 0x600000>;
+			no-map;
+		};
+	};
+};
+
+&uart0 {
+	status = "okay";
+};

-- 
2.50.0



^ permalink raw reply related	[flat|nested] 26+ messages in thread

* Re: [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC
  2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
                   ` (10 preceding siblings ...)
  2025-06-20 15:40 ` [PATCH 11/11] ARM: dts: mediatek: add basic support for Lenovo A369i board Max Shevchenko via B4 Relay
@ 2025-06-23  2:39 ` Rob Herring (Arm)
  11 siblings, 0 replies; 26+ messages in thread
From: Rob Herring (Arm) @ 2025-06-23  2:39 UTC (permalink / raw)
  To: Max Shevchenko
  Cc: Jiri Slaby, Daniel Lezcano, linux-watchdog, Greg Kroah-Hartman,
	Wim Van Sebroeck, Thomas Gleixner, Russell King, Conor Dooley,
	devicetree, linux-serial, linux-arm-kernel, Matthias Brugger,
	linux-kernel, linux-mediatek, AngeloGioacchino Del Regno,
	Sean Wang, Guenter Roeck, Krzysztof Kozlowski


On Fri, 20 Jun 2025 18:40:39 +0300, Max Shevchenko wrote:
> This series of patches adds support for the MT6572 SoC and
> the JTY D101 tablet and Lenovo A369i smartphone based on it.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---
> Max Shevchenko (11):
>       dt-bindings: serial: mediatek,uart: add MT6572
>       dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: add MT6572
>       dt-bindings: timer: mediatek: add MT6572
>       dt-bindings: watchdog: mediatek,mtk-wdt: add MT6572
>       dt-bindings: vendor-prefixes: add JTY
>       dt-bindings: arm: mediatek: add boards based on the MT6572 SoC
>       ARM: mediatek: show the hardware name for the MT6572
>       ARM: mediatek: add MT6572 smp bring up code
>       ARM: dts: mediatek: add basic support for MT6572 SoC
>       ARM: dts: mediatek: add basic support for JTY D101 board
>       ARM: dts: mediatek: add basic support for Lenovo A369i board
> 
>  .../devicetree/bindings/arm/mediatek.yaml          |   5 +
>  .../mediatek,mt6577-sysirq.yaml                    |   1 +
>  .../devicetree/bindings/serial/mediatek,uart.yaml  |   1 +
>  .../devicetree/bindings/timer/mediatek,timer.yaml  |   1 +
>  .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
>  .../bindings/watchdog/mediatek,mtk-wdt.yaml        |   1 +
>  arch/arm/boot/dts/mediatek/Makefile                |   2 +
>  arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts     |  62 ++++++++++++
>  arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts |  57 +++++++++++
>  arch/arm/boot/dts/mediatek/mt6572.dtsi             | 105 +++++++++++++++++++++
>  arch/arm/mach-mediatek/Kconfig                     |   4 +
>  arch/arm/mach-mediatek/mediatek.c                  |   1 +
>  arch/arm/mach-mediatek/platsmp.c                   |   7 ++
>  13 files changed, 249 insertions(+)
> ---
> base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
> change-id: 20250619-mt6572-ef78a3d45168
> 
> Best regards,
> --
> Max Shevchenko <wctrl@proton.me>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 0ff41df1cb268fc69e703a08a57ee14ae967d0ca

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/mediatek/' for 20250620-mt6572-v1-0-e2d47820f042@proton.me:

arch/arm/boot/dts/mediatek/mt6572-jty-d101.dtb: / (jty,d101): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[2147483648, 1073741824]]}
	from schema $id: http://devicetree.org/schemas/root-node.yaml#
arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dtb: / (lenovo,a369i): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[2147483648, 536870912]]}
	from schema $id: http://devicetree.org/schemas/root-node.yaml#






^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572
  2025-06-20 15:40 ` [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572 Max Shevchenko via B4 Relay
@ 2025-06-23  6:11   ` Krzysztof Kozlowski
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-23  6:11 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Thomas Gleixner, Daniel Lezcano,
	Wim Van Sebroeck, Guenter Roeck, Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

On 20/06/2025 17:40, Max Shevchenko via B4 Relay wrote:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add a compatible string for serial on the MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC
  2025-06-20 15:40 ` [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC Max Shevchenko via B4 Relay
@ 2025-06-23  6:12   ` Krzysztof Kozlowski
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-23  6:12 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Thomas Gleixner, Daniel Lezcano,
	Wim Van Sebroeck, Guenter Roeck, Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

On 20/06/2025 17:40, Max Shevchenko via B4 Relay wrote:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add basic support for the MediaTek MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---
>  arch/arm/boot/dts/mediatek/mt6572.dtsi | 105 +++++++++++++++++++++++++++++++++
>  1 file changed, 105 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mediatek/mt6572.dtsi b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..dd12231ca745be7455e99391abd2d708f2f1a8a9
> --- /dev/null
> +++ b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025 Max Shevchenko <wctrl@proton.me>
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "mediatek,mt6572";
> +	interrupt-parent = <&sysirq>;
> +
> +	cpus {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		enable-method = "mediatek,mt6589-smp";
> +
> +		cpu@0 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a7";
> +			reg = <0x0>;
> +		};
> +		cpu@1 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a7";
> +			reg = <0x1>;
> +		};
> +	};
> +
> +	system_clk: dummy13m {
> +		compatible = "fixed-clock";
> +		clock-frequency = <13000000>;
> +		#clock-cells = <0>;
> +	};
> +
> +	rtc_clk: dummy32k {
> +		compatible = "fixed-clock";
> +		clock-frequency = <32000>;
> +		#clock-cells = <0>;
> +	};
> +
> +	uart_clk: dummy26m {
> +		compatible = "fixed-clock";
> +		clock-frequency = <26000000>;
> +		#clock-cells = <0>;
> +	};
> +
> +	watchdog: watchdog@10007000 {

Missing soc node.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 10/11] ARM: dts: mediatek: add basic support for JTY D101 board
  2025-06-20 15:40 ` [PATCH 10/11] ARM: dts: mediatek: add basic support for JTY D101 board Max Shevchenko via B4 Relay
@ 2025-06-23  6:12   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-23  6:12 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Thomas Gleixner, Daniel Lezcano,
	Wim Van Sebroeck, Guenter Roeck, Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

On 20/06/2025 17:40, Max Shevchenko via B4 Relay wrote:
> +		framebuffer: framebuffer@bf400000 {
> +			compatible = "simple-framebuffer";
> +			memory-region = <&framebuffer_reserved>;
> +			width = <1024>;
> +			height = <600>;
> +			stride = <(1024 * 2)>;
> +			format = "r5g6b5";
> +			status = "okay";
Drop

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 03/11] dt-bindings: timer: mediatek: add MT6572
  2025-06-20 15:40 ` [PATCH 03/11] dt-bindings: timer: mediatek: " Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add a compatible string for timer on the MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 04/11] dt-bindings: watchdog: mediatek,mtk-wdt: add MT6572
  2025-06-20 15:40 ` [PATCH 04/11] dt-bindings: watchdog: mediatek,mtk-wdt: " Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add a compatible string for watchdog on the MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 06/11] dt-bindings: arm: mediatek: add boards based on the MT6572 SoC
  2025-06-20 15:40 ` [PATCH 06/11] dt-bindings: arm: mediatek: add boards based on the MT6572 SoC Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add entries for the JTY D101 tablet and the Lenovo A369i smartphone.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 02/11] dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: add MT6572
  2025-06-20 15:40 ` [PATCH 02/11] dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: " Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add a compatible string for sysirq on the MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 05/11] dt-bindings: vendor-prefixes: add JTY
  2025-06-20 15:40 ` [PATCH 05/11] dt-bindings: vendor-prefixes: add JTY Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> JTY produced low-cost Android tablets based on various
> MediaTek MT65xx SoCs.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>


Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572
  2025-06-20 15:40 ` [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572 Max Shevchenko via B4 Relay
  2025-06-23  6:11   ` Krzysztof Kozlowski
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add a compatible string for serial on the MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 07/11] ARM: mediatek: show the hardware name for the MT6572
  2025-06-20 15:40 ` [PATCH 07/11] ARM: mediatek: show the hardware name for the MT6572 Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add a compatible string for the MT6572 SoC.
> 

Please clarify the commit title.

ARM: mediatek: Add board_dt_compat entry for the MT6572 SoC

after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---
>   arch/arm/mach-mediatek/mediatek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
> index e6e9f93a1f01c7d043cf4312b9406b25c8897198..5c28124bd0078b31665fef647e496f4131b82c8d 100644
> --- a/arch/arm/mach-mediatek/mediatek.c
> +++ b/arch/arm/mach-mediatek/mediatek.c
> @@ -38,6 +38,7 @@ static void __init mediatek_timer_init(void)
>   
>   static const char * const mediatek_board_dt_compat[] = {
>   	"mediatek,mt2701",
> +	"mediatek,mt6572",
>   	"mediatek,mt6589",
>   	"mediatek,mt6592",
>   	"mediatek,mt7623",
> 



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 08/11] ARM: mediatek: add MT6572 smp bring up code
  2025-06-20 15:40 ` [PATCH 08/11] ARM: mediatek: add MT6572 smp bring up code Max Shevchenko via B4 Relay
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add support for booting the secondary CPU on the MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC
  2025-06-20 15:40 ` [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC Max Shevchenko via B4 Relay
  2025-06-23  6:12   ` Krzysztof Kozlowski
@ 2025-06-23  8:35   ` AngeloGioacchino Del Regno
  2025-06-23  9:49     ` Max Shevchenko
  1 sibling, 1 reply; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-23  8:35 UTC (permalink / raw)
  To: wctrl, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Thomas Gleixner, Daniel Lezcano, Wim Van Sebroeck, Guenter Roeck,
	Sean Wang, Russell King
  Cc: linux-kernel, linux-serial, devicetree, linux-arm-kernel,
	linux-mediatek, linux-watchdog

Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Add basic support for the MediaTek MT6572 SoC.
> 
> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---
>   arch/arm/boot/dts/mediatek/mt6572.dtsi | 105 +++++++++++++++++++++++++++++++++
>   1 file changed, 105 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mediatek/mt6572.dtsi b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..dd12231ca745be7455e99391abd2d708f2f1a8a9
> --- /dev/null
> +++ b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025 Max Shevchenko <wctrl@proton.me>
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "mediatek,mt6572";
> +	interrupt-parent = <&sysirq>;
> +
> +	cpus {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		enable-method = "mediatek,mt6589-smp";
> +
> +		cpu@0 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a7";
> +			reg = <0x0>;
> +		};
> +		cpu@1 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a7";
> +			reg = <0x1>;
> +		};
> +	};
> +
> +	system_clk: dummy13m {
> +		compatible = "fixed-clock";
> +		clock-frequency = <13000000>;
> +		#clock-cells = <0>;
> +	};
> +
> +	rtc_clk: dummy32k {
> +		compatible = "fixed-clock";
> +		clock-frequency = <32000>;
> +		#clock-cells = <0>;
> +	};
> +
> +	uart_clk: dummy26m {
> +		compatible = "fixed-clock";
> +		clock-frequency = <26000000>;
> +		#clock-cells = <0>;
> +	};
> +

Anything that has an MMIO address shall be child of "soc".

soc {
	watchdog@....

	timer@....

	etc.
};

> +	watchdog: watchdog@10007000 {
> +		compatible = "mediatek,mt6572-wdt",
> +			     "mediatek,mt6589-wdt";

those fit in one line:

compatible = "mediatek,mt6572-wdt", "mediatek,mt6589-wdt";

> +		reg = <0x10007000 0x100>;
> +		interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_LOW>;
> +		timeout-sec = <15>;
> +		#reset-cells = <1>;
> +	};
> +
> +	timer: timer@10008000 {
> +		compatible = "mediatek,mt6572-timer",
> +			     "mediatek,mt6577-timer";

same

> +		reg = <0x10008000 0x80>;
> +		interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&system_clk>, <&rtc_clk>;
> +		clock-names = "system-clk", "rtc-clk";
> +	};
> +
> +	sysirq: interrupt-controller@10200100 {
> +		compatible = "mediatek,mt6572-sysirq",
> +			     "mediatek,mt6577-sysirq";

same; and reg goes after compatible.

> +		interrupt-controller;
> +		#interrupt-cells = <3>;
> +		interrupt-parent = <&gic>;

are you sure that interrupt-parent is gic?

> +		reg = <0x10200100 0x1c>;
> +	};
> +
> +	gic: interrupt-controller@10211000 {
> +		compatible = "arm,cortex-a7-gic";

reg here.


> +		interrupt-controller;
> +		#interrupt-cells = <3>;
> +		interrupt-parent = <&gic>;

are you sure that the interrupt parent isn't sysirq here? :-)

> +		reg = <0x10211000 0x1000>,
> +		      <0x10212000 0x2000>,
> +		      <0x10214000 0x2000>,
> +		      <0x10216000 0x2000>;
> +	};
> +
> +	uart0: serial@11005000 {
> +		compatible = "mediatek,mt6572-uart",
> +			     "mediatek,mt6577-uart";

fits in one line

> +		reg = <0x11005000 0x400>;
> +		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&uart_clk>;

clock-names = .....

> +		status = "disabled";
> +	};
> +
> +	uart1: serial@11006000 {
> +		compatible = "mediatek,mt6572-uart",

...again.

> +			     "mediatek,mt6577-uart";
> +		reg = <0x11006000 0x400>;
> +		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&uart_clk>;
> +		status = "disabled";
> +	};
> +};
> 

Cheers,
Angelo

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC
  2025-06-23  8:35   ` AngeloGioacchino Del Regno
@ 2025-06-23  9:49     ` Max Shevchenko
  0 siblings, 0 replies; 26+ messages in thread
From: Max Shevchenko @ 2025-06-23  9:49 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: conor+dt@kernel.org, daniel.lezcano@linaro.org,
	devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux@armlinux.org.uk, linux@roeck-us.net, matthias.bgg@gmail.com,
	robh@kernel.org, sean.wang@mediatek.com, tglx@linutronix.de,
	wctrl@proton.me, wim@linux-watchdog.org


On Monday, June 23rd, 2025 at 11:35 AM, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:

> Il 20/06/25 17:40, Max Shevchenko via B4 Relay ha scritto:
>
> > From: Max Shevchenko wctrl@proton.me
> >
> > Add basic support for the MediaTek MT6572 SoC.
> >
> > Signed-off-by: Max Shevchenko wctrl@proton.me
> > ---
> > arch/arm/boot/dts/mediatek/mt6572.dtsi | 105 +++++++++++++++++++++++++++++++++
> > 1 file changed, 105 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mediatek/mt6572.dtsi b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..dd12231ca745be7455e99391abd2d708f2f1a8a9
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> > @@ -0,0 +1,105 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2025 Max Shevchenko wctrl@proton.me
> > + */
> > +
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +/ {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "mediatek,mt6572";
> > + interrupt-parent = <&sysirq>;
> > +
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + enable-method = "mediatek,mt6589-smp";
> > +
> > + cpu@0 {
> > + device_type = "cpu";
> > + compatible = "arm,cortex-a7";
> > + reg = <0x0>;
> > + };
> > + cpu@1 {
> > + device_type = "cpu";
> > + compatible = "arm,cortex-a7";
> > + reg = <0x1>;
> > + };
> > + };
> > +
> > + system_clk: dummy13m {
> > + compatible = "fixed-clock";
> > + clock-frequency = <13000000>;
> > + #clock-cells = <0>;
> > + };
> > +
> > + rtc_clk: dummy32k {
> > + compatible = "fixed-clock";
> > + clock-frequency = <32000>;
> > + #clock-cells = <0>;
> > + };
> > +
> > + uart_clk: dummy26m {
> > + compatible = "fixed-clock";
> > + clock-frequency = <26000000>;
> > + #clock-cells = <0>;
> > + };
> > +
>
>
> Anything that has an MMIO address shall be child of "soc".
>
> soc {
> watchdog@....
>
> timer@....
>
> etc.
> };
>
> > + watchdog: watchdog@10007000 {
> > + compatible = "mediatek,mt6572-wdt",
> > + "mediatek,mt6589-wdt";
>
>
> those fit in one line:
>
> compatible = "mediatek,mt6572-wdt", "mediatek,mt6589-wdt";
>
> > + reg = <0x10007000 0x100>;
> > + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_LOW>;
> > + timeout-sec = <15>;
> > + #reset-cells = <1>;
> > + };
> > +
> > + timer: timer@10008000 {
> > + compatible = "mediatek,mt6572-timer",
> > + "mediatek,mt6577-timer";
>
>
> same
>
> > + reg = <0x10008000 0x80>;
> > + interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&system_clk>, <&rtc_clk>;
> > + clock-names = "system-clk", "rtc-clk";
> > + };
> > +
> > + sysirq: interrupt-controller@10200100 {
> > + compatible = "mediatek,mt6572-sysirq",
> > + "mediatek,mt6577-sysirq";
>
>
> same; and reg goes after compatible.
>
> > + interrupt-controller;
> > + #interrupt-cells = <3>;
> > + interrupt-parent = <&gic>;
>
>
> are you sure that interrupt-parent is gic?

Other MT65xx devicetrees have GIC as parent for itself and SYSIRQ, so I assume.

>
> > + reg = <0x10200100 0x1c>;
> > + };
> > +
> > + gic: interrupt-controller@10211000 {
> > + compatible = "arm,cortex-a7-gic";
>
>
> reg here.
>
> > + interrupt-controller;
> > + #interrupt-cells = <3>;
> > + interrupt-parent = <&gic>;
>
>
> are you sure that the interrupt parent isn't sysirq here? :-)

not really, downstream has no mentions about SYSIRQ or its' address

>
> > + reg = <0x10211000 0x1000>,
> > + <0x10212000 0x2000>,
> > + <0x10214000 0x2000>,
> > + <0x10216000 0x2000>;
> > + };
> > +
> > + uart0: serial@11005000 {
> > + compatible = "mediatek,mt6572-uart",
> > + "mediatek,mt6577-uart";
>
>
> fits in one line
>
> > + reg = <0x11005000 0x400>;
> > + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&uart_clk>;
>
>
> clock-names = .....
>
> > + status = "disabled";
> > + };
> > +
> > + uart1: serial@11006000 {
> > + compatible = "mediatek,mt6572-uart",
>
>
> ...again.
>
> > + "mediatek,mt6577-uart";
> > + reg = <0x11006000 0x400>;
> > + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&uart_clk>;
> > + status = "disabled";
> > + };
> > +};
>
>
> Cheers,
> Angelo

thanks for suggestions, applied.


Sincerely,
Max

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2025-06-23  9:50 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 15:40 [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Max Shevchenko via B4 Relay
2025-06-20 15:40 ` [PATCH 01/11] dt-bindings: serial: mediatek,uart: add MT6572 Max Shevchenko via B4 Relay
2025-06-23  6:11   ` Krzysztof Kozlowski
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 02/11] dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: " Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 03/11] dt-bindings: timer: mediatek: " Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 04/11] dt-bindings: watchdog: mediatek,mtk-wdt: " Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 05/11] dt-bindings: vendor-prefixes: add JTY Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 06/11] dt-bindings: arm: mediatek: add boards based on the MT6572 SoC Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 07/11] ARM: mediatek: show the hardware name for the MT6572 Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 08/11] ARM: mediatek: add MT6572 smp bring up code Max Shevchenko via B4 Relay
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-20 15:40 ` [PATCH 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC Max Shevchenko via B4 Relay
2025-06-23  6:12   ` Krzysztof Kozlowski
2025-06-23  8:35   ` AngeloGioacchino Del Regno
2025-06-23  9:49     ` Max Shevchenko
2025-06-20 15:40 ` [PATCH 10/11] ARM: dts: mediatek: add basic support for JTY D101 board Max Shevchenko via B4 Relay
2025-06-23  6:12   ` Krzysztof Kozlowski
2025-06-20 15:40 ` [PATCH 11/11] ARM: dts: mediatek: add basic support for Lenovo A369i board Max Shevchenko via B4 Relay
2025-06-23  2:39 ` [PATCH 00/11] ASoC: mediatek: Add support for MT6572 SoC Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).