Re: [PATCH 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier()

Dikshita Agarwal
2026-04-23T09:52:34Z

On 4/23/2026 2:55 PM, Bryan O'Donoghue wrote:
> On 22/04/2026 12:16, Dikshita Agarwal wrote:
>> Fold the ternary initialiser directly into the variable declaration,
>> removing the dead store that was immediately overwritten.
>>
>> Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform
>> capabilities and properties")
>> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
>> ---
>>   drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> index
>> 30bfd90d423ba024caf6ececc827f7102e8f3324..06698fde639ec654ff9ec78a178271ab2284f5f0 100644
>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> @@ -536,10 +536,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst
>> *inst, u32 plane)
>>   {
>>       u32 port = iris_hfi_gen2_get_port(inst,
>> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
>>       struct iris_inst_hfi_gen2 *inst_hfi_gen2 =
>> to_iris_inst_hfi_gen2(inst);
>> -    u32 tier = inst->fw_caps[TIER].value;
>> -
>> -    tier = (inst->codec == V4L2_PIX_FMT_AV1) ?
>> inst->fw_caps[TIER_AV1].value :
>> +    u32 tier = (inst->codec == V4L2_PIX_FMT_AV1) ?
>> inst->fw_caps[TIER_AV1].value :
>>                               inst->fw_caps[TIER].value;
>> +
>>       inst_hfi_gen2->src_subcr_params.tier = tier;
>>
>>       return iris_hfi_gen2_session_set_property(inst,
>>
>> --
>> 2.34.1
>>
>
> I don't get it.
>
> What's the bug ?

It's not a bug, just removing the dead assignment.
Will remove fixes tag.

Thanks,
Dikshita
>
> ---
> bod