Re: [PATCH 2/7] media: qcom: iris: fix state-change debug log printing stale value

Bryan O'Donoghue
2026-04-23T09:18:29Z

On 22/04/2026 12:16, Dikshita Agarwal wrote:
> The state‑change debug log in iris_inst_change_state() always prints the
> same value for the old and new state, rendering it useless for
> debugging. This happens because the state is updated before the log is
> emitted.
>
> Log the transition before updating the state so the previous value is
> preserved, consistent with the existing sub‑state handling.
>
> Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops")
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c
> index d14472414750dc7edc4834f32a51f2c5adc3762e..e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8 100644
> --- a/drivers/media/platform/qcom/iris/iris_state.c
> +++ b/drivers/media/platform/qcom/iris/iris_state.c
> @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst,
> return -EINVAL;
>
> change_state:
> - inst->state = request_state;
> dev_dbg(inst->core->dev, "state changed from %x to %x\n",
> inst->state, request_state);
> + inst->state = request_state;
>
> return 0;
> }
>
> --
> 2.34.1
>

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>